docs: ensure github pages have proper base

dynamicmsw · Mar 3, 2024 · 9225141 · 9225141
1 parent c58434b
commit 9225141
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 9 deletions.
diff --git a/.github/workflows/deploy-static-github-pages.yml b/.github/workflows/deploy-static-github-pages.yml
@@ -7,6 +7,7 @@ on:
   push:
     branches:
       - main
+      - fix-github-page
 
 jobs:
   build-storybook:
@@ -43,7 +44,7 @@ jobs:
         run: npx nx run-many -t build -p storybook
         env:
           STORYBOOK_PREVIEW: true
-          STORYBOOK_PUBLIC_PATH: /dynamic-msw/
+          VITE_STORYBOOK_PUBLIC_PATH: /dynamic-msw/
           NX_CLOUD_ACCESS_TOKEN: ${{ secrets.NX_CLOUD_ACCESS_TOKEN }}
       - name: Upload artifact
         uses: actions/upload-pages-artifact@v3

diff --git a/.github/workflows/quality-assurance.yml b/.github/workflows/quality-assurance.yml
@@ -5,10 +5,7 @@ concurrency:
   cancel-in-progress: true
 
 on:
-  pull_request:
   push:
-    branches:
-      - main
 
 jobs:
   quality-assurance:

diff --git a/apps/storybook/.storybook/main.ts b/apps/storybook/.storybook/main.ts
@@ -13,8 +13,8 @@ const config: StorybookConfig = {
     },
   },
   managerHead: (head) => {
-    if (!process.env.STORYBOOK_PUBLIC_PATH) return head;
-    return `${head}<base href="${process.env.STORYBOOK_PUBLIC_PATH}">`;
+    if (!process.env.VITE_STORYBOOK_PUBLIC_PATH) return head;
+    return `${head}<base href="${process.env.VITE_STORYBOOK_PUBLIC_PATH}">`;
   },
   viteFinal: (viteConfig) =>
     mergeConfig(viteConfig, {

diff --git a/apps/storybook/src/examples/ProductPage.stories.tsx b/apps/storybook/src/examples/ProductPage.stories.tsx
@@ -3,6 +3,9 @@ import ProductPage from './ProductPage';
 
 const meta: Meta<typeof ProductPage> = {
   component: ProductPage,
+  parameters: {
+    layout: 'fullscreen',
+  },
 };
 
 export default meta;

diff --git a/apps/storybook/src/test-utils/dashboardSetup.ts b/apps/storybook/src/test-utils/dashboardSetup.ts
@@ -15,4 +15,6 @@ const setup = setupDashboard(
     renderDashboardButton: true, // true by default
   }
 );
-await setup.start({ onUnhandledRequest: 'bypass' });
+await setup.start({
+  onUnhandledRequest: 'bypass',
+});
diff --git a/apps/storybook/vite.config.ts b/apps/storybook/vite.config.ts
@@ -10,7 +10,6 @@ process.env.VITE_DASHBOARD_HTML = getDashboardHTML();
 export default defineConfig({
   root: __dirname,
   cacheDir: '../../node_modules/.vite/apps/storybook',
-  base: process.env.STORYBOOK_PUBLIC_PATH || '/',
   server: {
     port: 4200,
     host: 'localhost',

diff --git a/nx.json b/nx.json
@@ -98,7 +98,7 @@
     "@nx/storybook:build": {
       "cache": true,
       "dependsOn": ["^build"],
-      "inputs": ["storybook"]
+      "inputs": ["storybook", { "runtime": "echo $VITE_STORYBOOK_PUBLIC_PATH" }]
     },
     "@nx/storybook:serve": {
       "cache": true,