feat: custom denom for gas fees #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -237,7 +237,7 @@ func (k *Keeper) ApplyTransaction(ctx sdk.Context, tx *ethtypes.Transaction) (*t | |||
| } | |||
|
|
|||
| // refund gas in order to match the Ethereum gas consumption instead of the default SDK one. | |||
| if err = k.RefundGas(ctx, msg, msg.Gas()-res.GasUsed, cfg.Params.EvmDenom); err != nil { | |||
| if err = k.RefundGas(ctx, msg, msg.Gas()-res.GasUsed, cfg.Params.GasDenom); err != nil { | |||
There was a problem hiding this comment.
So GasDenom is forced to not empty? Imo should have a ticket to note the migration require this setting.
There was a problem hiding this comment.
You wrote in the docs: On genesis, this parameter is empty (optionally, it equals to evm_denom)
There was a problem hiding this comment.
that's true, I chose the latter. thought it's more seamless.
There was a problem hiding this comment.
@omritoptix FYI please make sure we don't forget to add value for this param on upgrade.
VictorTrustyDev
approved these changes
Dec 12, 2024
| return errortypes.ErrInsufficientFee.Wrapf( | ||
| "wrong fee denomination; got: %s; required: %s", amount, stakingDenom, | ||
| ) | ||
| // amount is not in staking denom, do not try to claim staking rewards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements the following: https://www.notion.so/dymension/Tx-gas-payment-using-optional-denom-in-EVM-106a4a51f86a803a81fdf43be998c93c?pvs=4#106a4a51f86a808c9ae7e989a1f211cd
We cannot use ERC-20 token as a tx fee since currently everything fee-related is tied to SDK coins (eg in CLI you specify fees using SDK coins). Specifically, FeeTx interface. The solution is to always use an SDK representation of token and convert from ERC-20 to SDK if necessary.
This PR modifies AnteHandlers.
Cosmos Ante
Evm Ante
Important changes:
Closes dymensionxyz/rollapp-evm#383