Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: change ethermint dependency to evmos repo #512

Merged

Conversation

mtsitrin
Copy link
Contributor

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin linked an issue Jan 25, 2024 that may be closed by this pull request
@mtsitrin mtsitrin marked this pull request as ready for review February 4, 2024 14:02
@mtsitrin mtsitrin requested a review from a team as a code owner February 4, 2024 14:02
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 28 lines in your changes are missing coverage. Please review.

Comparison is base (9c1be1f) 30.87% compared to head (940ae88) 31.07%.

Files Patch % Lines
app/ante/handlers.go 25.00% 24 Missing ⚠️
app/ante/ante_options.go 0.00% 2 Missing and 1 partial ⚠️
app/ante/ante.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #512      +/-   ##
==========================================
+ Coverage   30.87%   31.07%   +0.20%     
==========================================
  Files         166      165       -1     
  Lines       25383    25221     -162     
==========================================
+ Hits         7836     7837       +1     
+ Misses      16299    16135     -164     
- Partials     1248     1249       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtsitrin
Copy link
Contributor Author

mtsitrin commented Feb 7, 2024

Blocked by
dymensionxyz/evmos#19
dymensionxyz/evmos#16

@mtsitrin mtsitrin changed the base branch from main to release/v4.x.x February 11, 2024 09:37
@mtsitrin mtsitrin merged commit 9c157f2 into release/v4.x.x Feb 11, 2024
4 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/504-change-ethermint-dependency-to-evmos-repo branch February 11, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change ethermint dependency to evmos repo
2 participants