Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(iro): removed ibc filter for VFC creation #1302

Merged
merged 3 commits into from
Oct 10, 2024

Conversation

mtsitrin
Copy link
Contributor

Description


Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin mtsitrin requested a review from a team as a code owner October 10, 2024 10:40
@mtsitrin mtsitrin linked an issue Oct 10, 2024 that may be closed by this pull request
@VictorTrustyDev
Copy link
Contributor

@mtsitrin does the iro tokens has a prefix?
How about just accept whitelisted prefix like ibc/ and iro/ prefixes instead of allow all?
That would help us get rid of unwanted cases.

@mtsitrin
Copy link
Contributor Author

@mtsitrin does the iro tokens has a prefix? How about just accept whitelisted prefix like ibc/ and iro/ prefixes instead of allow all? That would help us get rid of unwanted cases.

we currently trigger the VFC creation explicitly through x/denommetadata module
so I think it's already filters out unwanted cases
currently, its can be triggered by gov proposal, ibc middleware with rollapps, and IRO

x/vfc/hooks/denom_metadata_hooks.go Outdated Show resolved Hide resolved
@omritoptix omritoptix merged commit d1125ef into main Oct 10, 2024
19 of 164 checks passed
@omritoptix omritoptix deleted the mtsitrin/1301-iro-tokens-dont-create-vfc-contract branch October 10, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IRO tokens dont create VFC contract
3 participants