-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(dymns): persist EIP-155 part only, for RollApp-related configs, to avoid migration when RollApp chain-id changed #1285
Conversation
…here are 3 format types
…s it should be handled by MsgServer to make correct decision
…d so no need migration
…when it is RollApp
if anyUpdated { | ||
err := k.SetDymName(ctx, dymName) | ||
if err != nil { | ||
panic(err) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
for alias := range unique { | ||
uniqueAliases = append(uniqueAliases, alias) | ||
} |
Check warning
Code scanning / CodeQL
Iteration over map Warning
func (am AppModule) BeginBlock(_ sdk.Context, _ abci.RequestBeginBlock) {} | ||
func (am AppModule) BeginBlock(ctx sdk.Context, _ abci.RequestBeginBlock) { | ||
// TODO DymNS: delete this | ||
am.keeper.BeginBlockMigrationForPlayground(ctx) |
Check warning
Code scanning / CodeQL
Panic in BeginBock or EndBlock consensus methods Warning
path flow from Begin/EndBlock to a panic call
No need for now. |
Description
Closes #1078
To avoid data migration when a RollApp chain-id changed due to fraud,...
x/dymns
now adjust logic to save only EIP-155 part (ra_100-1
=>100
) instead of Full chain-id.This PR contains:
ChainID
field of Dym-Name config.x/rollapp
keeper:IsRollAppExists(string) bool
GetRollAppIdByEIP155(string) string
cc: @omritoptix @danwt
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
For Reviewer:
After reviewer approval: