Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(iro): scale the bonding curve #1247

Merged
merged 89 commits into from
Sep 27, 2024
Merged

feat(iro): scale the bonding curve #1247

merged 89 commits into from
Sep 27, 2024

Conversation

mtsitrin
Copy link
Contributor

Description

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@mtsitrin
genereated proto files
e48ae3f
@mtsitrin
fixed proto
b6ecec8
@mtsitrin
scaffold
ec02a4d
@mtsitrin
store keys
c5ee033
@mtsitrin
initial store getters
70f179e
@mtsitrin
implemented create plan
ffbb44a
@mtsitrin
implemented trade methods and linear bonding curve
4f45328
@mtsitrin
implemented the cur
59c6fed
@mtsitrin
wired keeper, and started testing
48eb399
@mtsitrin
implemented bonding curve and create plan
ac7ff90
@mtsitrin
first UT pass
030f450
@mtsitrin
bond curve fix and UT
abfb8c5
@mtsitrin
trade test
0ba4c5c
@mtsitrin
added curve params to the plan
b9ebf1c
@mtsitrin
using curve from plan
d9a1818
@mtsitrin
Merge branch 'main' into feature/IRO
a6bf24f
@mtsitrin
refactor genesistransfer. added transferEnabled hook
bca38d8
@mtsitrin
UT compiles
33c09d6
@mtsitrin
genesis transfer UT
8b69ae8
@mtsitrin
genesis test
0d18586
@mtsitrin
implemented queries
eb7fcf1
@mtsitrin
module account for plan
1033813
@mtsitrin
fixed module account
2e1d0c3
@mtsitrin
fixed validation test
3e74625
@mtsitrin
liquidity bootstrap wip
3178c9f
@mtsitrin
fixed claim. added buying allocation limit
f55fada
@mtsitrin
creating pool
d1c22d6
@mtsitrin
UT wip
63e25d1
@mtsitrin
IRO creation fee
63adb6d
@mtsitrin
linter
35b464e
@mtsitrin mtsitrin requested a review from a team as a code owner September 24, 2024 13:49
@mtsitrin mtsitrin linked an issue Sep 24, 2024 that may be closed by this pull request
feat(IRO): scale the bonding curve #1218
Closed
@mtsitrin mtsitrin marked this pull request as draft September 24, 2024 14:39
@mtsitrin mtsitrin marked this pull request as ready for review September 25, 2024 09:30
omritoptix
omritoptix previously approved these changes Sep 26, 2024
View reviewed changes
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non blocker comment and questions

app/keepers/keepers.go
@@ -117,7 +117,6 @@ type AppKeepers struct {
ParamsKeeper paramskeeper.Keeper
IBCKeeper *ibckeeper.Keeper // IBC Keeper must be a pointer in the app, so we can SetRouter on it correctly
TransferStack ibcporttypes.IBCModule
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's unused. just cleanup

x/iro/types/bonding_curve.go
*/

const (
MaxNValue = 10
MaxPrecision = 2
MaxNValue = 2 // Maximum allowed value for the N parameter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why we changed to 2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewing real world scenarios, can't see how it can be usable
even N=2 is probably too high
the initial N=10 was out of the blue

x/iro/types/bonding_curve.go Outdated
*/

// Scales x from it's base denomination to a decimal representation
// This is used so the bonding curve
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cut-off comment?

@mtsitrin mtsitrin merged commit f88af02 into main Sep 27, 2024
114 of 126 checks passed
@mtsitrin mtsitrin deleted the mtsitrin/1218-featiro-scale-the-bonding-curve branch September 27, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omritoptix omritoptix omritoptix left review comments

Assignees
No one assigned
Labels
dym-internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(IRO): scale the bonding curve
2 participants
@mtsitrin @omritoptix