Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rollapp): fix packet lookup for non-rollapp chain-id #1243

Merged
merged 15 commits into from
Sep 25, 2024

Conversation

danwt
Copy link
Contributor

@danwt danwt commented Sep 23, 2024

Description


Closes #1241

Changes:

  • crucial logic in x/rollapp/keeper/authenticate_packet.go
  • Now we will fetch the rollapp by light client directly, not by the chain ID on the light client
  • Also deprecates numBlocks field on state info and fixes tests

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Targeted PR against the correct branch
  • included the correct type prefix in the PR title
  • Linked to the GitHub issue with discussion and accepted design
  • Targets only one GitHub issue
  • Wrote unit and integration tests
  • Wrote relevant migration scripts if necessary
  • All CI checks have passed
  • Added relevant godoc comments
  • Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
  • Add an issue in the e2e-tests repo if necessary

SDK Checklist

  • Import/Export Genesis
  • Registered Invariants
  • Registered Events
  • Updated openapi.yaml
  • No usage of go map
  • No usage of time.Now()
  • Used fixed point arithmetic and not float arithmetic
  • Avoid panicking in Begin/End block as much as possible
  • No unexpected math Overflow
  • Used sendCoin and not SendCoins
  • Out-of-block compute is bounded
  • No serialized ID at the end of store keys
  • UInt to byte conversion should use BigEndian

Full security checklist here


For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
  • In case the PR targets a release branch, PR must be rebased.

@danwt danwt marked this pull request as ready for review September 23, 2024 15:22
@danwt danwt requested a review from a team as a code owner September 23, 2024 15:22
@omritoptix omritoptix changed the title Danwt/1241 fix rollapp lookup in packet receipt fix(rollapp): fix packet lookup for non-rollapp chain-id Sep 23, 2024
omritoptix
omritoptix previously approved these changes Sep 23, 2024
Copy link
Contributor

@omritoptix omritoptix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved with one small question/comment.

@danwt danwt merged commit 61d5018 into main Sep 25, 2024
111 of 126 checks passed
@danwt danwt deleted the danwt/1241-fix-rollapp-lookup-in-packet-receipt branch September 25, 2024 09:51
danwt added a commit that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix handling same chain ID non rollapp and rollapp
3 participants