fix(iro): creating VFC contracts for IRO tokens (#1314)

dymensionxyz · Oct 13, 2024 · 7119731 · 7119731
1 parent c8b8406
commit 7119731
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 7 deletions.
diff --git a/app/keepers/keepers.go b/app/keepers/keepers.go
@@ -395,6 +395,7 @@ func (a *AppKeepers) InitKeepers(
 		authtypes.NewModuleAddress(govtypes.ModuleName).String(),
 		&a.AccountKeeper,
 		a.BankKeeper,
+		a.DenomMetadataKeeper,
 		a.RollappKeeper,
 		a.GAMMKeeper,
 		a.IncentivesKeeper,

diff --git a/testutil/keeper/iro.go b/testutil/keeper/iro.go
@@ -37,6 +37,7 @@ func IROKeeper(t testing.TB) (*keeper.Keeper, sdk.Context) {
 		nil,
 		nil,
 		nil,
+		nil,
 	)
 
 	ctx := sdk.NewContext(stateStore, tmproto.Header{}, false, log.NewNopLogger())

diff --git a/x/iro/keeper/create_plan.go b/x/iro/keeper/create_plan.go
@@ -164,13 +164,13 @@ func (k Keeper) MintAllocation(ctx sdk.Context, allocatedAmount math.Int, rollap
 		return sdk.Coin{}, errorsmod.Wrap(errors.Join(gerrc.ErrInternal, err), fmt.Sprintf("metadata: %v", metadata))
 	}
 
-	if k.BK.HasDenomMetaData(ctx, baseDenom) {
-		return sdk.Coin{}, errors.New("denom already exists")
+	err := k.dk.CreateDenomMetadata(ctx, metadata)
+	if err != nil {
+		return sdk.Coin{}, errorsmod.Wrap(err, "create denom metadata")
 	}
-	k.BK.SetDenomMetaData(ctx, metadata)
 
 	minted := sdk.NewCoin(baseDenom, allocatedAmount)
-	err := k.BK.MintCoins(ctx, types.ModuleName, sdk.NewCoins(minted))
+	err = k.BK.MintCoins(ctx, types.ModuleName, sdk.NewCoins(minted))
 	if err != nil {
 		return sdk.Coin{}, err
 	}

diff --git a/x/iro/keeper/create_plan_test.go b/x/iro/keeper/create_plan_test.go
@@ -122,6 +122,10 @@ func (s *KeeperTestSuite) TestMintAllocation() {
 	_, found := s.App.BankKeeper.GetDenomMetaData(s.Ctx, expectedBaseDenom)
 	s.Require().True(found)
 
+	// assert virtual frontier bank contract created
+	found = s.App.EvmKeeper.HasVirtualFrontierBankContractByDenom(s.Ctx, expectedBaseDenom)
+	s.Require().True(found)
+
 	// assert coins minted
 	s.Assert().True(allocatedAmount.Equal(minted.Amount))
 	coins := s.App.BankKeeper.GetSupply(s.Ctx, expectedBaseDenom)

diff --git a/x/iro/keeper/keeper.go b/x/iro/keeper/keeper.go
@@ -21,6 +21,7 @@ type Keeper struct {
 
 	AK types.AccountKeeper
 	BK types.BankKeeper
+	dk types.DenomMetadataKeeper
 	rk types.RollappKeeper
 	gk types.GammKeeper
 	pm types.PoolManagerKeeper
@@ -33,6 +34,7 @@ func NewKeeper(
 	authority string,
 	ak types.AccountKeeper,
 	bk types.BankKeeper,
+	dk types.DenomMetadataKeeper,
 	rk types.RollappKeeper,
 	gk types.GammKeeper,
 	ik types.IncentivesKeeper,
@@ -44,6 +46,7 @@ func NewKeeper(
 		authority: authority,
 		AK:        ak,
 		BK:        bk,
+		dk:        dk,
 		rk:        rk,
 		gk:        gk,
 		ik:        ik,

diff --git a/x/iro/types/expected_keepers.go b/x/iro/types/expected_keepers.go
@@ -21,12 +21,14 @@ type AccountKeeper interface {
 	SetModuleAccount(ctx sdk.Context, macc authtypes.ModuleAccountI)
 }
 
+type DenomMetadataKeeper interface {
+	CreateDenomMetadata(ctx sdk.Context, metadata banktypes.Metadata) error
+	HasDenomMetadata(ctx sdk.Context, base string) bool
+}
+
 // BankKeeper defines the expected interface needed to retrieve account balances.
 type BankKeeper interface {
 	GetBalance(ctx sdk.Context, addr sdk.AccAddress, denom string) sdk.Coin
-	HasDenomMetaData(ctx sdk.Context, denom string) bool
-	SetDenomMetaData(ctx sdk.Context, denomMetaData banktypes.Metadata)
-
 	SendCoins(ctx sdk.Context, fromAddr sdk.AccAddress, toAddr sdk.AccAddress, amt sdk.Coins) error
 	SendCoinsFromModuleToAccount(ctx sdk.Context, senderModule string, recipientAddr sdk.AccAddress, amt sdk.Coins) error
 	SendCoinsFromAccountToModule(ctx sdk.Context, senderAddr sdk.AccAddress, recipientModule string, amt sdk.Coins) error