Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the music button on the main menu not working #108

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

Thompson6626
Copy link
Contributor

@Thompson6626 Thompson6626 commented May 24, 2024

👉 Checklist

Please make sure to check off the following before submitting:

  • [✅] I have reviewed my submission thoroughly.
  • [✅] I have tested my code (if submission is related to coding) and run the game before pushing (to make sure the project compile).
  • [✅] I have run the JUnit tests (if submission is related to coding).
  • [✅] I have read the Code of Conduct and Contribution Guidelines.

✍ Description of the Pull Request

Please concisely describe the changes you have made.
I've fixed the following issues:

  • Fixed an issue where the music button did not turn music back on after being turned off.
  • Fixed a bug where the background music from the game wouldn't stop when returning to the main menu.
  • Added a playing music image to differentiate between muted and unmuted states.

🔗 Issue link

Issue reference number and link goes here e.g. 'Fixes/Closes #<issue_number>'.


Thanks for taking the time to fill out this Pull Request! ❤️ Thanks for contributing to this project 🦖

… a new image displaying that the music is playing
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @Thompson6626, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify your PR is up-to-date with the repository /dinosaur-exploder main branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
  • ✅ Verify that you have well fill out the different checkboxes in the PR template.
  • ⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.
  • 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

Copy link
Collaborator

@jvondermarck jvondermarck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the long review !! I will just change the icon for the sound, it wasn't the best solution to make a random drawing with the wrong green color aha, but otherwise it is all good, thanks a lot for your contribution.

@jvondermarck jvondermarck merged commit c037483 into dylan-power:main Aug 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: impossible to turn the music back on
2 participants