Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update Dialog overlay and scrolling tvchart #922

Merged
merged 2 commits into from
Aug 19, 2024

Conversation

aforaleka
Copy link
Contributor

@aforaleka aforaleka commented Aug 14, 2024

when trader is on Trade page, they probably still want to be able to see useful trade info (oracle price, price charts) etc.
replace overlay blur with an overlay dark tint, clicking outside will close the dialog. intentional to let them still scroll and interact with TradingView.

image

@aforaleka aforaleka requested a review from a team as a code owner August 14, 2024 20:52
Copy link

linear bot commented Aug 14, 2024

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 9:54pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 9:54pm

@aforaleka aforaleka force-pushed the aleka/ct-1070-ability-to-see-chart-while-placing-sltp branch from c65c7d3 to 1a6e62d Compare August 15, 2024 21:49
@aforaleka aforaleka requested a review from jaredvu August 16, 2024 18:57
@aforaleka aforaleka changed the title chore: add props to Dialog to control overlay and click outside behavior chore: update Dialog overlay and scrolling tvchart Aug 16, 2024
@aforaleka aforaleka merged commit df4eb6f into main Aug 19, 2024
11 checks passed
@aforaleka aforaleka deleted the aleka/ct-1070-ability-to-see-chart-while-placing-sltp branch August 19, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants