Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fee tier market share percentage should show 1 decimal #842

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

aforaleka
Copy link
Contributor

before:
image

after:
image

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 9:18pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 9:18pm

@@ -27,6 +27,8 @@ import { getFeeTiers } from '@/state/configsSelectors';

import { isTruthy } from '@/lib/isTruthy';

const MARKET_SHARE_PERCENTAGE_FRACTION_DIGITS = 1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: can we move this to Numbers.ts?

@aforaleka aforaleka merged commit 938d60c into main Jul 22, 2024
6 checks passed
@aforaleka aforaleka deleted the ac/fix-user-fee-tiers-percentage-rounding branch July 22, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants