feat: change onboarding acknowledgement flow #831
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| import { Link } from '@/components/Link'; | ||
| import { TermsOfUseLink } from '@/components/TermsOfUseLink'; | ||
|
|
||
| export const AcknowledgeTermsDialog = ({ setIsOpen }: DialogProps<AcknowledgeTermsDialogProps>) => { |
There was a problem hiding this comment.
This is mostly moved from OnboardingDialog/AcknowledgeTerms to its own Dialog.
| @@ -3,7 +3,6 @@ import type { DydxAddress, EvmAddress } from './wallets'; | |||
| export enum OnboardingSteps { | |||
| ChooseWallet = 'ChooseWallet', | |||
| KeyDerivation = 'KeyDerivation', | |||
| AcknowledgeTerms = 'AcknowledgeTerms', | |||
There was a problem hiding this comment.
No longer need AcknowledgeTerms as an OnboardingStep
rosepuppy
changed the title
|
General thought: why is the acknowledge link so small/in the corner? Can we make the acknowledge terms and deposit button open up that modal instead? |
I think the idea, is that we don't really need to show the modal unless the user wants to read the whole thing. The acknowledgement will be implicit when they deposit. Basically if they just click the deposit CTA, they don't need to view the ack modal at all. I think we were seeing drop offs during the ack modal and we want to skip that step. |
| @@ -273,6 +287,10 @@ export const DepositForm = ({ onDeposit, onError }: DepositFormProps) => { | |||
|
|
|||
| setIsLoading(true); | |||
|
|
|||
| if (!hasAcknowledgedTerms) { | |||
| saveHasAcknowledgedTerms(true); | |||
There was a problem hiding this comment.
Set acknowledgement on deposit
oh i see, i misinterpreted and thought the reason why the "acknowledge and deposit" button was greyed out on your screen was becasue you hadn't accepted terms and conditions, but it was just because no amount was populated for the deposit. is that correct? |
Correct |
OLD:
Screen.Recording.2024-07-18.at.11.15.56.AM.mov
NEW:
Screen.Recording.2024-07-18.at.10.51.47.AM.mov
Update onboarding acknowledgement flow based on this https://linear.app/dydx/issue/OTE-318/update-onboarding-flow-to-reduce-friction-for-users