feat(new market): have other market validation run on diff only #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
reviewed
Jun 21, 2024
| - name: Get diff of otherMarketData.json | ||
| run: | | ||
| git fetch origin | ||
| git diff remotes/origin/main -- public/configs/otherMarketData.json > otherMarketDiff.txt |
There was a problem hiding this comment.
is there any cleanup of otherMarketDiff after?
There was a problem hiding this comment.
i think it's just part of the workflow. so when workflow finishes, everything is cleaned up
jaredvu
approved these changes
Jun 21, 2024
This was referenced Jun 21, 2024
DavideSegullo
pushed a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 26, 2024
DavideSegullo
added a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 26, 2024
* feat: ➕ add export-to-csv dep * feat: ✨ add download icon * feat: ✨ add navigation menu slots * feat: ✨ add csv utility * feat: 🏷️ improve dropdown menu types * refactor: ♻️ refactor Output component refactored Output component to export formatting utils. * feat: ✨ add ExportHistoryDropdown component * feat: ✨ add export inside History page added ExportHistoryDropdown component inside History page layout. * feat: 🚸 disable csv export on empty data * feat: 📈 add export history analytics * fix: 🐛 fix export history download * fix: 🐛 fix post merge errors * feat: ✨ add reusable format number function * refactor: ♻️ add better style declaration * fix: 🐛 fix post merge errors * fix: 🐛 fix react errors * fix: 🐛 fix empty export * feat: ⬆️ upgrade @dydxprotocol/v4-client-js * feat: ✨ add history export all services * feat: ✨ add export loading states * refactor: 🎨 improve format of the code * style: 🚨 fix lint errors * style: 🚨 add default case * feat: ✨ add export sorting in decreasing order * feat: ✨ add price column inside csv * fix: add back precision to earned by stakers (dydxprotocol#692) * fix(sparklines): bump abacus and fix output component (dydxprotocol#695) * feat(staking): ui of validator selection (dydxprotocol#691) * chore: replace spread row with mid market price row (dydxprotocol#696) * chore(hide-gasToggle): temp hide gas toggle (dydxprotocol#700) * chore: improve order statuses (dydxprotocol#693) * fix(subaccount-transfer): enforce senderAddress matches localWallet (dydxprotocol#703) * feat: update to use proxy for staking apr (dydxprotocol#702) * chore: remove deprecated params [OTE-353] (dydxprotocol#698) * feat: add ZK, ZRO, NCAT to the widget (dydxprotocol#704) * feat(staking): polishes (dydxprotocol#701) * feat: improve markets page style (dydxprotocol#699) * feat: ⬆️ upgrade @dydxprotocol/v4-client-js * feat: ✨ add parentSubaccount export * feat: ✨ disable export on disconnection state * feat(staking): add staking live notif (dydxprotocol#708) * feat(new market): have other market validation run on diff only (dydxprotocol#705) * feat: redirect other reward pages after staking is turned on (dydxprotocol#711) * docs: 📝 improve comment format * fix: 🐛 fix merge error * style: 🚨 fix lint errors * feat: fix invert tag for certain raydium markets (dydxprotocol#709) Co-authored-by: jaredvu <[email protected]> * chore(default-page): change default page to /markets (dydxprotocol#713) * chore(staking): remove last faq question (dydxprotocol#712) * feat: add tracking to staking (dydxprotocol#710) * fix: polishes for staking (dydxprotocol#716) * fix: nonzero rewards (dydxprotocol#653) * chore: fully type dialogs, fix some more any types, redo analytics (dydxprotocol#671) * fix: fix validator url icon (dydxprotocol#720) * chore(new-market): update header copy (dydxprotocol#718) * feat(mobile-download): Add mobile app store download links (dydxprotocol#717) * feat: preload metadata for all markets in otherMarketData.json (dydxprotocol#646) Co-authored-by: jaredvu <[email protected]> * fix: isolated positions bug fixes + auto-open (dydxprotocol#721) * feat: orderbook refresh + updates (dydxprotocol#647) * chore: install-local-l10n command (dydxprotocol#697) * chore: use FormMaxInputToggleButton in transfer/deposit/withdraw forms (dydxprotocol#715) * fix: fix updated terms of use link (dydxprotocol#724) * fix: orderbook bugs (dydxprotocol#725) * style(nits): update exchange billboards and stats, assetIcons (dydxprotocol#726) * feat: update zk logo and zro zk logo data (dydxprotocol#727) * feat: skip track/status endpoints [OTE-354] (dydxprotocol#719) * fix(disconnect-cleanup): set localWallet and hdKey to undefined when disconnecting (dydxprotocol#728) * fix: analytics property names (dydxprotocol#730) * style(tables): update table header styling (dydxprotocol#729) * feat: ✨ add new analytics api --------- Co-authored-by: moo-onthelawn <[email protected]> Co-authored-by: Jared Vu <[email protected]> Co-authored-by: aleka <[email protected]> Co-authored-by: Bill <[email protected]> Co-authored-by: Jeremy Lee <[email protected]> Co-authored-by: yujin512 <[email protected]> Co-authored-by: Tian <[email protected]> Co-authored-by: tyleroooo <[email protected]>
DavideSegullo
pushed a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 26, 2024
DavideSegullo
pushed a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 26, 2024
DavideSegullo
added a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 28, 2024
chore: override post order position margin for full close position on isolated market (dydxprotocol#670) fix: fix decimal places on order size/amount in positions + orders table (dydxprotocol#675) chore(staking): (un)stake form polishes (dydxprotocol#658) chore: set privy app client id (dydxprotocol#660) fix: handle partially canceled orders (dydxprotocol#679) fix(staking): add faq + fix unflagged fetch of trading rewards data (dydxprotocol#681) feat: cancel trigger orders automatically / abacus bump (dydxprotocol#682) chore: abacus enum casing + remove cancelOrder param (dydxprotocol#683) chore(adjust-margin): add additional validation (dydxprotocol#668) chore(abacus): bump to 1.7.83 (dydxprotocol#677) Co-authored-by: aforaleka <[email protected]> feat: add raydium markets to the widget (dydxprotocol#533) Co-authored-by: jaredvu <[email protected]> Co-authored-by: Bill <[email protected]> Co-authored-by: tyleroooo <[email protected]> Co-authored-by: moo-onthelawn <[email protected]> Co-authored-by: Tian Qin <[email protected]> Co-authored-by: Nikhil Vasan <[email protected]> fix(new-market-filter): remove isolated filter (dydxprotocol#688) feat(staking): claim rewards transaction (+ simulation) (dydxprotocol#648) fix: Recently Listed Markets View Sorted by `clobPairId` (dydxprotocol#689) chore: bump abacus (dydxprotocol#690) feat: share PNL analytics (dydxprotocol#678) fix: add back precision to earned by stakers (dydxprotocol#692) fix(sparklines): bump abacus and fix output component (dydxprotocol#695) feat(staking): ui of validator selection (dydxprotocol#691) chore: replace spread row with mid market price row (dydxprotocol#696) chore(hide-gasToggle): temp hide gas toggle (dydxprotocol#700) chore: improve order statuses (dydxprotocol#693) fix(subaccount-transfer): enforce senderAddress matches localWallet (dydxprotocol#703) feat: update to use proxy for staking apr (dydxprotocol#702) chore: remove deprecated params [OTE-353] (dydxprotocol#698) feat: add ZK, ZRO, NCAT to the widget (dydxprotocol#704) feat(staking): polishes (dydxprotocol#701) feat: improve markets page style (dydxprotocol#699) feat(staking): add staking live notif (dydxprotocol#708) feat(new market): have other market validation run on diff only (dydxprotocol#705) feat: redirect other reward pages after staking is turned on (dydxprotocol#711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have market validation only run on added/modified markets (instead of the entire JSON) as the JSON has a large number of markets and running validation on all of them every time is time-consuming