chore (incentives): season 4 reward distributed notification #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yogurtandjam
approved these changes
Jun 6, 2024
There was a problem hiding this comment.
LGTM
some thoughts:
- would recommend creating a
SEASON_NUMBERconst so we can just update that from here on out. - maybe we should think about making a
CURRENT_SEASON_NOTIFICATIONso we we can just update that instead of all the references toReleaseUpdateNotificationIds
src/hooks/useNotificationTypes.tsx
Outdated
| body: `Season 3 rewards: +${dydxRewards ?? 0} ${chainTokenLabel}`, | ||
| title: stringGetter({ | ||
| key: 'NOTIFICATIONS.REWARDS_DISTRIBUTED.TITLE', | ||
| params: { SEASON_NUMBER: 4 }, |
There was a problem hiding this comment.
nice, love that you made a l10n string for this.
ooh yes, updated
Done! |
moo-onthelawn
deleted the
mulan/ote-342-season-3-notifications-distributed
branch
DavideSegullo
added a commit
to nabla-studio/v4-web
that referenced
this pull request
Jun 28, 2024
chore: show all markets w/o pagination on market page (dydxprotocol#573) chore: run auto fix on /views/forms (dydxprotocol#561) fix: clear inputs on close position click to avoid subsequent place orders (dydxprotocol#577) chore: make trade form footer not sticky depending on screen height + table column header nits (dydxprotocol#576) chore: enable traders to cancel "BEST_EFFORT_CANCELED" stateful orders (dydxprotocol#574) chore: move rewards history start date into env feature flag (dydxprotocol#578) chore: finish fixing lint errors in /views (dydxprotocol#562) chore: eslint everywhere else (dydxprotocol#567) chore: remove all other index files with exports (dydxprotocol#571) chore: pnpm cleanup tasks: prune, dedupe (dydxprotocol#575) chore: remove unused types, exports, variables, functions, etc (dydxprotocol#579) chore: add lint to pr actions (dydxprotocol#586) fix: Update mintscanBase and add android force update test data (dydxprotocol#583) fix: type check records correctly (dydxprotocol#589) chore(incentives): Update notification for incentives season 5 (dydxprotocol#590) chore: create historical rewards chart (dydxprotocol#591) chore: properly type more style mixins (dydxprotocol#595) chore: upgrade react query to v5 (dydxprotocol#568) Co-authored-by: aleka <[email protected]> feat: add W metadata (dydxprotocol#608) feat: update fills tab number logic to count unseen fills only (dydxprotocol#606) chore: type custom events (dydxprotocol#565) feat: enable memo field on transfers of token (dydxprotocol#613) chore: fix super zoomed out orderbook (dydxprotocol#614) chore: upgrade and fix redux typings (dydxprotocol#604) feat: add equity tiers to portfolio (dydxprotocol#597) chore: bump eslint and friends (dydxprotocol#609) chore: learn more link in equity tier broadcast error (dydxprotocol#603) fix: clean up selector console errors (dydxprotocol#619) feat: implement basic Staking/unstaking (dydxprotocol#611) chore: update trading rewards table styling, pr followups (dydxprotocol#602) chore: clean remaining redux uses from main (dydxprotocol#621) chore: update trading rewards faq (dydxprotocol#622) fix: switch market selector dropdown to infinite scroll (dydxprotocol#624) chore: migrate governance + market pages onto trading rewards page (flagged) (dydxprotocol#605) chore: deprecate fok (dydxprotocol#627) feat: Self-served MFA modal (dydxprotocol#612) Signed-off-by: Yuyo <[email protected]> feat: Prompt MFA after sign up (dydxprotocol#620) Signed-off-by: Yuyo <[email protected]> chore: make sl/tp rectangles clickable (dydxprotocol#628) chore: padding / real estate (dydxprotocol#629) feat: pipe unbondingDelegations and stakingRewards from abacus (dydxprotocol#631) feat(staking): add in geoblock panel, rearrange widgets (dydxprotocol#626) chore: script to cut new tags (dydxprotocol#517) feat: update validation flow to finish despite errors (dydxprotocol#635) feat(staking): implement claim rewards panel + dialog (dydxprotocol#632) feat(new market widget): fix long type of validation script (dydxprotocol#640) feat: Enable Compliance (dydxprotocol#642) chore: audit all typecasts, make safer where possible (dydxprotocol#633) feat: add UI for unbonding delegations (dydxprotocol#639) chore(staking): merge tradingrewardsrehaul + enablestaking flags (dydxprotocol#641) chore: season 4 reward distributed notification (dydxprotocol#645) chore: market wind down notifications (dydxprotocol#644) chore: add min fraction digits to price for page title (dydxprotocol#650) fix: update markets fee estimation (dydxprotocol#652) fix(staking): fix up staking panel colors (dydxprotocol#655) chore(abacusv2): update to asyncAbacusStateManagerV2 (dydxprotocol#580) Co-authored-by: Jeremy Lee <[email protected]> Co-authored-by: Bill He <[email protected]> feat(isolated-markets): Enable Isolated Margin Trading (dydxprotocol#541) Co-authored-by: tyleroooo <[email protected]> Co-authored-by: Jeremy Lee <[email protected]> Co-authored-by: moo-onthelawn <[email protected]> Co-authored-by: Bill He <[email protected]> Co-authored-by: aleka <[email protected]> Co-authored-by: Prashan Dharmasena <[email protected]> feat(isolated-margin-live): Add notification for Isolated Margin (dydxprotocol#662) Co-authored-by: tyleroooo <[email protected]> Co-authored-by: Jeremy Lee <[email protected]> Co-authored-by: moo-onthelawn <[email protected]> Co-authored-by: Bill He <[email protected]> Co-authored-by: aleka <[email protected]> Co-authored-by: Prashan Dharmasena <[email protected]> fix(staking): fix unstaking validator names not showing on initial render (dydxprotocol#661) chore(sltp): update trigger edit button flow/styling (dydxprotocol#643) chore: make almost everything selectable (dydxprotocol#665) fix: orderbook price -> input conversion (dydxprotocol#666) chore(liquidation-price): use tickSizeDecimals (dydxprotocol#667) chore(gas): reserve 0.50 usdc (dydxprotocol#669) feat(rebalance-wallet): rebalance wallet if usdcBalance is low (dydxprotocol#672)
moo-onthelawn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distribute s4 notifs
will hold merge until rewards are actually distributed but ready for review