Add support for OKX wallet #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rosepuppy
commented
Feb 16, 2024
| @@ -18,15 +19,6 @@ export const isMetaMask = (provider: ExternalProvider) => ( | |||
| && ( | |||
| !(provider as InjectedCoinbaseWalletExtensionProvider).overrideIsMetaMask | |||
| ) | |||
|
|
|||
| /* not a MetaMask wannabe! */ | |||
| && ( | |||
There was a problem hiding this comment.
Removed this because some wallets such as OKX wallet purposely override the metamask ethereum provider and this check prevents the override and would skip the provider altogether. This will then fallback to WalletConnect.
I think we should not do this as it should not be the dApp's call on how the user choose to manage there wallet extension defaults/overrides. If the user wants to override their metamask with another wallet, we should let them.
rosepuppy
force-pushed
the
okx-wallet
branch
from
a8008e5 to
b020c3a
Compare
rosepuppy
force-pushed
the
okx-wallet
branch
from
b020c3a to
4e03197
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on dydxprotocol/v4-localization#285
Screen.Recording.2024-02-16.at.11.50.33.AM.mov