Cex withdraw #301
Merged
Cex withdraw #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rosepuppy
force-pushed
the
cex-withdraw
branch
from
188ba55 to
903c008
Compare
jaredvu
reviewed
Feb 16, 2024
Comment on lines
+35
to
+46
| export function validateCosmosAddress(address: string, prefix: string) { | ||
| try { | ||
| // Decode the address to verify its structure and prefix | ||
| const { prefix: decodedPrefix } = fromBech32(address); | ||
|
|
||
| // Check if the decoded address has the expected prefix | ||
| return decodedPrefix === prefix; | ||
| } catch (error) { | ||
| // If decoding fails, the address is not valid | ||
| return false; | ||
| } | ||
| } |
There was a problem hiding this comment.
good candidate to add to tests
jaredvu
reviewed
Feb 16, 2024
jaredvu
reviewed
Feb 16, 2024
rosepuppy
force-pushed
the
cex-withdraw
branch
from
903c008 to
9e9bf8c
Compare
jaredvu
reviewed
Feb 16, 2024
jaredvu
reviewed
Feb 16, 2024
jaredvu
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-02-13.at.10.09.47.PM.mov
depends on dydxprotocol/v4-abacus#220 and dydxprotocol/v4-localization#273
Views
src/views/dialogs/DepositDialog.tsxsrc/views/dialogs/OnboardingDialog.tsxsrc/views/dialogs/DepositDialog/DepositDialogContent.tsxsrc/views/forms/AccountManagementForms/DepositForm.tsxsrc/views/forms/AccountManagementForms/TokenSelectMenu.tsxsrc/views/forms/AccountManagementForms/WithdrawForm.tsxsrc/views/forms/AccountManagementForms/WithdrawForm/WithdrawButtonAndReceipt.tsxsrc/views/forms/NobleDeposit.tsxsrc/views/notifications/TransferStatusNotification/index.tsxComponents
src/components/SearchSelectMenu.tsx--stickyArea1-topHeightifwithSearchis false, since you won't want to make room for the search inputsrc/components/TimeoutButton.tsxonTimeoutcallbackConstants/Types
src/constants/analytics.tsFunctions
src/lib/addressUtils.tsHooks
src/hooks/useLocalNotifications.tsxsrc/hooks/useNotificationTypes.tsxPackages
abacusandv4-localization