feat: migrate positions table to abacus-ts #1375
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const numTotalPositions = (useAppSelector(selectParentSubaccountOpenPositions) ?? EMPTY_ARR) | ||
| .length; |
There was a problem hiding this comment.
ok for now. but i feel like we get this num in multiple places. might be good to move to a hook
| }; | ||
| }, [position, stringGetter]); | ||
|
|
||
| return ( | ||
| <TableCell | ||
| slotRight={ | ||
| marginMode === AbacusMarginMode.Isolated && ( | ||
| marginMode === 'ISOLATED' && ( |
There was a problem hiding this comment.
Would it be worth adding MarginMode enums?
| @@ -29,31 +27,33 @@ export const PositionsMarginCell = ({ position }: PositionsMarginCellProps) => { | |||
| const dispatch = useAppDispatch(); | |||
|
|
|||
| const { marginMode, margin } = useMemo(() => { | |||
| const { childSubaccountNumber } = position; | |||
| const derivedMarginMode = getMarginModeFromSubaccountNumber(childSubaccountNumber); | |||
| const { marginMode: marginModeInner, marginValueInitial } = position; | |||
There was a problem hiding this comment.
not in love with the Inner suffix haha
| asset != null | ||
| ? ({ | ||
| id: asset.id, | ||
| name: asset.name, | ||
| tags: [], | ||
| resources: { imageUrl: asset.logo }, | ||
| } as unknown as Asset) | ||
| : undefined |
There was a problem hiding this comment.
can this be updated w/ selectAllAssetsInfo -> selectAssetInfoFromId (new selector). Can probably call selector from <MarketTableCell marketId={...} />
|
|
||
| const openPositions = useAppSelector(getExistingOpenPositions, shallowEqual) ?? EMPTY_ARR; | ||
| const perpetualMarkets = orEmptyRecord(useAppSelector(selectRawMarketsData)); |
There was a problem hiding this comment.
why use rawMarketsData instead of selectAllMarketsInfo?
There was a problem hiding this comment.
w/ rebase you'll be able to get assetId, tickSizeDecimals, etc.
There was a problem hiding this comment.
it might make sense to convert all values to bigNumber within calculateMarkets as well
No description provided.