Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(notification-menu): dismiss on click outside #1370

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

jaredvu
Copy link
Contributor

@jaredvu jaredvu commented Dec 13, 2024

Small clean-up and re-add overlay on Notifications Menu.


Views

  • <NotificationsMenu>
    • add withOverlay when not tablet to allow for dismiss on click outside

@jaredvu jaredvu requested a review from a team as a code owner December 13, 2024 21:32
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:32pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:32pm

@jaredvu jaredvu merged commit acef77b into main Dec 16, 2024
9 checks passed
@jaredvu jaredvu deleted the jv/notifications-dismiss branch December 16, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants