-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add marketmap validation script #1272
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a lot of this script seems to be redundant with validate-other-market-data.ts? perhaps we can reuse variables?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's the purpose of this script?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially replacing that script, which will no longer be needed with the PML feature launch because the widget will not be populated from the JSON, but instead from metadata service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i see. mainly just a rename then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied that script and made various improvements and added new validation checks
closing because stale, feel free to reopen |
Views
New:
<ViewComponentName>
<ViewComponentName>
→
Components
New:
<ComponentName>
<ComponentName>
→
Styles/Mixins
styles/_____
→
Constants/Types
constants/_____
Functions/Clients
lib/_____
Hooks
hooks/_____
State
state/_____
Packages
package-name
Workflows
workflow-name.yml