Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add marketmap validation script #1272

Closed
wants to merge 1 commit into from

Conversation

chenyaoy
Copy link
Contributor


Views

  • New: <ViewComponentName>

  • <ViewComponentName>

    • New: ``
    • Rename:

Components

  • New: <ComponentName>

  • <ComponentName>

    • New: ``
    • Rename:

Styles/Mixins

  • styles/_____
    • New: ``
    • Rename:

Constants/Types

  • constants/_____

Functions/Clients

  • lib/_____

Hooks

  • hooks/_____

State

  • state/_____

Packages

  • package-name
    • updated: v** -> v**

Workflows

  • workflow-name.yml

@chenyaoy chenyaoy requested a review from a team as a code owner November 12, 2024 18:55
@chenyaoy chenyaoy requested review from tqin7 and removed request for a team November 12, 2024 18:55
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:58pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 12, 2024 6:58pm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a lot of this script seems to be redundant with validate-other-market-data.ts? perhaps we can reuse variables?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the purpose of this script?

Copy link
Contributor Author

@chenyaoy chenyaoy Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is essentially replacing that script, which will no longer be needed with the PML feature launch because the widget will not be populated from the JSON, but instead from metadata service

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i see. mainly just a rename then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied that script and made various improvements and added new validation checks

@tinaszheng
Copy link
Contributor

tinaszheng commented Nov 27, 2024

image

image

@chenyaoy
Copy link
Contributor Author

image image

lol 99.9% of the changes are for a JSON that's autogenerated that we perform the validation over

@tyleroooo
Copy link
Contributor

closing because stale, feel free to reopen

@tyleroooo tyleroooo closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants