feat: useTransfers hook [OTE-853] #1137

yogurtandjam · 2024-10-14T21:54:01Z

Adds usetransfers hook that takes the place of abacus state.

Some cleanup around the native chain address variable.
The native chain address can be represented as either {chain_name}_native (skip API response + requests) and 0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE (cosmJS + wagmi response/requests). We need to account for both now

linear · 2024-10-14T21:54:04Z

OTE-853 UseTransfers Hook

vercel · 2024-10-14T21:54:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
v4-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 5:51pm
v4-testnet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Oct 18, 2024 5:51pm

src/views/forms/AccountManagementForms/DepositForm.tsx

tinaszheng

nice work jeremy!

src/constants/cctp.ts

src/constants/transfers.ts

tinaszheng · 2024-10-15T15:48:28Z

src/constants/transfers.ts

+  const defaultTokenDenom = cctpToken?.denom ?? nativeChainToken?.denom ?? assets[0]?.denom;
+  return defaultTokenDenom;


Suggested change

const defaultTokenDenom = cctpToken?.denom ?? nativeChainToken?.denom ?? assets[0]?.denom;

return defaultTokenDenom;

return cctpToken?.denom ?? nativeChainToken?.denom ?? assets[0]?.denom;

maybe leave a comment about why assets[0] would be valid here?

oh forgot to add a response here:

added the comment!

personally prefer to keep declaration and return value separate for code that's in development, makes things slightly more convenient to debug. down to roll into a capstone PR and add a comment though

src/hooks/transfers/useTransfers.tsx

src/lib/assetUtils.ts

src/views/forms/AccountManagementForms/DepositForm.tsx

remcve skip core limit memory usememo address comments

cleanup add tests use skip client hook instead of lib

yogurtandjam · 2024-10-18T17:10:58Z

src/hooks/transfers/useTransfers.tsx

+      if (isTokenCctp(fromToken)) {
+        // CCTP Deposits
+        return skipClient.msgsDirect({
+          ...(baseParams as MsgsDirectRequest),


[fix] this doesn't need to be here

yogurtandjam · 2024-10-18T17:12:11Z

src/hooks/transfers/useTransfers.tsx

+    queryFn: async () => {
+      // this should never happen, this is just to satisfy typescript
+      // react queries should never return null.
+      if (!hasAllParams || !fromToken.decimals) return null;


[fix] i should probably actually be throwing an error here

tinaszheng · 2024-10-18T17:08:08Z

src/hooks/transfers/skipClient.tsx

      }),
+      skipClientId: crypto.randomUUID(),


👀 what is this clientId supposed to represent? can you leave a comment?

ooo good point! will do :)

tinaszheng · 2024-10-18T17:14:33Z

src/hooks/transfers/useTransfers.tsx

+        allowUnsafe: true,
+        slippageTolerancePercent: '1',
+        smartRelay: true,
+        // TODO [onboarding-rewrite]: talk to skip about this, why are decimals optional? when would that happen?


move TODO to line 170?

oh actually good point, we actually know why this happens now i'll update this comment

tinaszheng · 2024-10-18T17:15:14Z

src/App.tsx

+      queryKey: ['transferEligibleAssets', skipClientId],
+      queryFn: () => assetsQueryFn(skipClient),
+    });
+  }, [skipClient]);


wont hurt to also just add in skipClientId here to get rid of the lint warning

tinaszheng · 2024-10-18T17:15:51Z

src/App.tsx

@@ -100,6 +104,17 @@ const Content = () => {
    }
  }, [dispatch]);

+  useEffect(() => {


can you move this to a separate hook, or its own React component called <PreloadedQueries /> or something?

yogurtandjam requested a review from a team as a code owner October 14, 2024 21:54

vercel bot deployed to Preview – v4-staging October 14, 2024 21:56 View deployment

vercel bot deployed to Preview – v4-testnet October 14, 2024 21:56 View deployment

yogurtandjam commented Oct 14, 2024

View reviewed changes

src/views/forms/AccountManagementForms/DepositForm.tsx Outdated Show resolved Hide resolved

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from 223ceca to 3f05f3d Compare October 14, 2024 22:10

vercel bot had a problem deploying to Preview – v4-testnet October 14, 2024 22:14 Failure

vercel bot deployed to Preview – v4-staging October 14, 2024 22:14 View deployment

vercel bot had a problem deploying to Preview – v4-staging October 14, 2024 22:23 Failure

vercel bot deployed to Preview – v4-testnet October 14, 2024 22:24 View deployment

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from 8f319ae to 3f4510e Compare October 14, 2024 22:48

vercel bot had a problem deploying to Preview – v4-staging October 14, 2024 22:49 Failure

vercel bot had a problem deploying to Preview – v4-testnet October 14, 2024 22:49 Failure

vercel bot deployed to Preview – v4-staging October 15, 2024 00:50 View deployment

vercel bot deployed to Preview – v4-testnet October 15, 2024 00:50 View deployment

tinaszheng reviewed Oct 15, 2024

View reviewed changes

Base automatically changed from jerms/OTE-857_useSkipClient to main October 15, 2024 19:03

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from e87f259 to 5424002 Compare October 15, 2024 20:53

yogurtandjam requested a review from tinaszheng October 15, 2024 20:55

vercel bot had a problem deploying to Preview – v4-testnet October 15, 2024 20:59 Failure

vercel bot deployed to Preview – v4-staging October 15, 2024 21:00 View deployment

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from 5424002 to fd49261 Compare October 15, 2024 22:55

vercel bot had a problem deploying to Preview – v4-staging October 15, 2024 22:58 Failure

vercel bot had a problem deploying to Preview – v4-testnet October 15, 2024 22:58 Failure

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from fd49261 to 161146b Compare October 15, 2024 23:00

vercel bot deployed to Preview – v4-testnet October 15, 2024 23:09 View deployment

vercel bot deployed to Preview – v4-staging October 15, 2024 23:09 View deployment

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from 2709192 to 43b39a9 Compare October 15, 2024 23:41

vercel bot deployed to Preview – v4-testnet October 15, 2024 23:47 View deployment

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from 3271240 to 2202ef9 Compare October 18, 2024 15:58

yogurtandjam and others added 7 commits October 18, 2024 11:59

feat: useSkipClient hook [OTE-857]

403c6e8

remcve skip core limit memory usememo address comments

feat: usetransfers hook [OTE-853]

6f8e35f

cleanup add tests use skip client hook instead of lib

address comments

687d297

consolidate native denom const

6e30c28

address comments!

b37f0c6

feat: cctp withdrawals: setup [1/n] (#1152)

75c0100

add refetch interval for route query

2cd87e1

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from 2202ef9 to 2cd87e1 Compare October 18, 2024 15:59

vercel bot deployed to Preview – v4-testnet October 18, 2024 16:06 View deployment

vercel bot deployed to Preview – v4-staging October 18, 2024 16:06 View deployment

lint

b5aeb6a

vercel bot deployed to Preview – v4-testnet October 18, 2024 16:59 View deployment

vercel bot deployed to Preview – v4-staging October 18, 2024 16:59 View deployment

yogurtandjam commented Oct 18, 2024

View reviewed changes

remove unused typecase

749ad54

yogurtandjam commented Oct 18, 2024

View reviewed changes

throw error instead of returning null

ea8a116

tinaszheng approved these changes Oct 18, 2024

View reviewed changes

vercel bot deployed to Preview – v4-testnet October 18, 2024 17:20 View deployment

vercel bot deployed to Preview – v4-staging October 18, 2024 17:20 View deployment

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from b953249 to e943b6e Compare October 18, 2024 17:43

comment for clientid + token.decimals, prefetchedQuery hook

aa5a089

yogurtandjam force-pushed the jerms/OTE-853_usetransfers-hook branch from e943b6e to aa5a089 Compare October 18, 2024 17:44

tinaszheng approved these changes Oct 18, 2024

View reviewed changes

yogurtandjam enabled auto-merge (squash) October 18, 2024 17:50

vercel bot deployed to Preview – v4-testnet October 18, 2024 17:51 View deployment

vercel bot deployed to Preview – v4-staging October 18, 2024 17:51 View deployment

yogurtandjam merged commit 6322d60 into main Oct 18, 2024
8 checks passed

yogurtandjam deleted the jerms/OTE-853_usetransfers-hook branch October 18, 2024 17:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: useTransfers hook [OTE-853] #1137

feat: useTransfers hook [OTE-853] #1137

yogurtandjam commented Oct 14, 2024 •

edited

Loading

linear bot commented Oct 14, 2024

vercel bot commented Oct 14, 2024 •

edited

Loading

tinaszheng left a comment

tinaszheng Oct 15, 2024

yogurtandjam Oct 17, 2024

yogurtandjam Oct 18, 2024

yogurtandjam Oct 18, 2024

tinaszheng Oct 18, 2024

yogurtandjam Oct 18, 2024

tinaszheng Oct 18, 2024

yogurtandjam Oct 18, 2024

tinaszheng Oct 18, 2024

tinaszheng Oct 18, 2024

		const defaultTokenDenom = cctpToken?.denom ?? nativeChainToken?.denom ?? assets[0]?.denom;
		return defaultTokenDenom;

	const defaultTokenDenom = cctpToken?.denom ?? nativeChainToken?.denom ?? assets[0]?.denom;
	return defaultTokenDenom;
	return cctpToken?.denom ?? nativeChainToken?.denom ?? assets[0]?.denom;

feat: useTransfers hook [OTE-853] #1137

feat: useTransfers hook [OTE-853] #1137

Conversation

yogurtandjam commented Oct 14, 2024 • edited Loading

linear bot commented Oct 14, 2024

vercel bot commented Oct 14, 2024 • edited Loading

tinaszheng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yogurtandjam commented Oct 14, 2024 •

edited

Loading

vercel bot commented Oct 14, 2024 •

edited

Loading