Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix stacking of characters #1136

Conversation

moo-onthelawn
Copy link
Contributor

@moo-onthelawn moo-onthelawn commented Oct 14, 2024

  • pull in new translations
  • fix stacking of characters in tabs
  • note, I verified that "Depth" is a translation key (DEPTH_CHART_SHORT) it's just that japanese happened to translate it as "Depth" :( (will find channel to circuit feedback into)
before after
Screenshot 2024-10-14 at 5 25 15 PM Screenshot 2024-10-14 at 5 28 13 PM
Screenshot 2024-10-14 at 5 40 30 PM Screenshot 2024-10-14 at 5 40 21 PM
Screenshot 2024-10-14 at 5 43 56 PM Screenshot 2024-10-14 at 5 44 07 PM

@moo-onthelawn moo-onthelawn requested a review from a team as a code owner October 14, 2024 21:23
Copy link

vercel bot commented Oct 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
v4-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 9:43pm
v4-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 14, 2024 9:43pm

Copy link

linear bot commented Oct 14, 2024

@moo-onthelawn moo-onthelawn merged commit b497228 into main Oct 14, 2024
13 checks passed
@moo-onthelawn moo-onthelawn deleted the mulan/ct-1289-unflagged-audit-asian-languages-for-stacking-of-characters branch October 14, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants