Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useSkipClient hook [OTE-857] #1133

Merged
merged 3 commits into from
Oct 15, 2024
Merged

feat: useSkipClient hook [OTE-857] #1133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1df5b5a
feat: useSkipClient hook [OTE-857]
yogurtandjam Oct 14, 2024
bf65466
remcve skip core
yogurtandjam Oct 14, 2024
7d13b78
address comments
yogurtandjam Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"scripts": {
"dev": "cp ./template.html ./index.html && vite",
"build": "pnpm run build:set-last-commit-and-tag && pnpm run build:generate-entry-points && tsc && vite build",
"build": "NODE_OPTIONS='--max_old_space_size=8192' pnpm run build:set-last-commit-and-tag && pnpm run build:generate-entry-points && tsc && vite build",
Copy link
Contributor Author

@yogurtandjam yogurtandjam Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our builds are starting to OOM. vercel points out 3 primary suspects:

  • large number of dependencies
  • large data handling
  • inefficient code

we haven't added any data handling and none of the code here is really has the opportunity to very inefficient in terms of build size.

so the primary theory is that our dependencies list has grown big enough where we need to up our node limits. if node crashes via OOM it can cause the vercel container to 137 exit, so we're following vercel's recommendation to increase the node heap size BUT we should probably still revisit this to optimize our build a bit.

"build:inject-app-deeplinks": "sh scripts/inject-app-deeplinks.sh",
"build:inject-amplitude": "node scripts/inject-amplitude.js",
"build:inject-google-tag-manager": "node scripts/inject-google-tag-manager.js",
Expand Down Expand Up @@ -97,7 +97,7 @@
"@reduxjs/toolkit": "^2.2.5",
"@scure/bip32": "^1.3.0",
"@scure/bip39": "^1.2.0",
"@skip-router/core": "^5.1.0",
"@skip-go/client": "0.10.3",
"@solana/web3.js": "^1.93.0",
"@statsig/js-client": "1.4.0",
"@statsig/react-bindings": "1.4.0",
Expand Down
Loading
Loading