fix: change tv datafeed to hook for reset cache #1131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aforaleka
force-pushed
the
fix-tv-candles-reset
branch
from
082a5f2 to
b495225
Compare
jaredvu
reviewed
Oct 14, 2024
jaredvu
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idk what exactly is wrong, but bug was introduced with calling
onResetCacheNeededCallbackinsubscribeBarswhich in hindsight seems bad; some value is unexpectedly null and older candles aren't processed correctly. removing that fixes it, but we'll still want to reset the cache when display unit is updated and then call reset on chartfix: make the datafeed function into a hook to save the reference to onResetCacheNeededCallback, so we can call it in the right place and not every time we subscribe bars
testing: