fix: update mobile web trade form for better ux experience on isolated trades #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tyleroooo
reviewed
Oct 4, 2024
src/styles/layoutMixins.ts
Outdated
| @@ -44,6 +44,7 @@ const scrollAreaFadeStart = css` | |||
|
|
|||
| /* Rules */ | |||
| position: relative; | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
gotta imagine this is going to cause pain SOMEWHERE, but I've got no clue where
There was a problem hiding this comment.
oh rip good catch - it's preventing the "More" dropdown from showing. Man lemme fix
| @@ -397,6 +412,12 @@ const $TradeForm = styled.form` | |||
| } | |||
| `; | |||
|
|
|||
| const $Content = styled.div` | |||
There was a problem hiding this comment.
mildly prefer just inlining these short ones (except FadeContainer) with tw=
moo-onthelawn
commented
Oct 14, 2024
src/components/ToggleGroup.tsx
Outdated
| const [showFadeStart, setShowFadeStart] = useState(false); | ||
| const [showFadeEnd, setShowFadeEnd] = useState(false); | ||
|
|
||
| const handleScroll = useCallback((e: UIEvent<HTMLElement>) => { |
There was a problem hiding this comment.
potentially could move this into a hook too 👀
aforaleka
approved these changes
Oct 14, 2024
aforaleka
approved these changes
Oct 15, 2024
moo-onthelawn
deleted the
mulan/ct-1267-unflagged-update-trade-form-for-mobile-view
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no designs for this yet, this is just to tide us over until ui refresh designs come in; should match what we have in web
iphone SE
Views
New:
<TradeSideTabs>New:
forms/TradeForm/MarginAndLeverageButtons<TradeForm>currentStepis not null only in mobile / tablet viewsTradeBoxOrderViewTradeSideTabsandMarginAndLeverageButtonscomponent, remove mostly unnecessarytabsStyleComponents
TradeDialogEditOrderstep so that the new header is justTrade, and we have theTradeSideTabsandMarginAndLeverageButtonsin the content of the dialogIconDelete:
TradeSideToggleComponents
<Collapsible>TriggerIconsizing to match with--trigger-icon-width<Icon>TabsuseFadeOnHorizontalScrollContainerto auto apply fadeToggleGroupuseFadeOnHorizontalScrollContainerto auto apply fadeHooks
useFadeOnHorizontalScrollContainerStyles
<layoutMixins>overflow: hiddento fade mixins