feat(uirefresh): component refresh - market selector #1073
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
src/components/Separator.tsx
Outdated
| height: ${({ fullHeight }) => css` | ||
| ${fullHeight ? css`100%;` : css`calc(100% - 1.5rem);`} | ||
| `} |
There was a problem hiding this comment.
nit: do we need the double css`` wrapping?
| className?: string; | ||
| }; | ||
|
|
||
| export const SortIcon = ({ sortDirection, className }: ElementProps & StyleProps) => { |
There was a problem hiding this comment.
coool i dig this! superrrr nit since in the preview link i feel like they look a little too cartoonish(?) -- can we align it more like the one in figma so the two vertical lines of the arrows are closer to same height?
There was a problem hiding this comment.
ah yes - lemme update with achal's icons!
| placeholder={stringGetter({ key: searchPlaceholderKey })} | ||
| onTextChange={onSearchTextChange} | ||
| /> | ||
| {uiRefresh && showProposeButton && showLaunchMarkets && launchMarketButton} |
There was a problem hiding this comment.
is adding the showLaunchMarkets to determine whether to show propose button an intentional change? since we used to just show the button when showProposeButton is true
There was a problem hiding this comment.
yess - so was following logic for when we enable the Launch Market route here - since the route doesn't exist unless pml is enabled, I also hide it here. Note that the existing "Propose markets" button logic doesn't change
src/views/MarketsDropdown.tsx
Outdated
| { | ||
| columnKey: 'oraclePrice', | ||
| getCellValue: (row) => row.oraclePrice, | ||
| label: stringGetter({ key: STRING_KEYS.PRICE }), | ||
| renderCell: ({ oraclePrice, tickSizeDecimals }) => ( | ||
| <$Output type={OutputType.Fiat} value={oraclePrice} fractionDigits={tickSizeDecimals} /> | ||
| ), | ||
| }, | ||
| } satisfies ColumnDef<MarketData>, |
There was a problem hiding this comment.
could we potentially add this at the end and do something like satisfies ColumnDef<MarketData>[]?
moo-onthelawn
deleted the
mulan/ct-1217-component-refresh-market-selector
branch
Update the market selector + dropdown for the ui refresh. Most changes flagged. See figma here.
Mainly:
Note:
uirefresh=true, and would addpml=truefor the launch markets buttonViews
MarketSelectorAndStatsMarketStatsDetailsMarketFilteruirefreshenabled:pmlflag as well)MarketDropdownuirefreshenabled:uirefreshenabledComponents
SearchInputSortIconTableSortIconwhen flag enabledToggleGroupSeparatorVerticalSeparatorPackages
localization