show warning icon in place order CTA only when validation error is un…

…related to missing fields
dydxprotocol · Aug 13, 2024 · dc7f8a6 · dc7f8a6
1 parent 5ecd0f7
commit dc7f8a6
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/src/views/forms/TradeForm/PlaceOrderButtonAndReceipt.tsx b/src/views/forms/TradeForm/PlaceOrderButtonAndReceipt.tsx
@@ -101,7 +101,7 @@ export const PlaceOrderButtonAndReceipt = ({
 
   const { fee, price: expectedPrice, reward } = summary ?? {};
 
-  // check if required fields are filled and summary has been calculated
+  // approximation for whether inputs are filled by whether summary has been calculated
   const areInputsFilled = fee != null || reward != null;
 
   const renderMarginValue = () => {
@@ -289,7 +289,7 @@ export const PlaceOrderButtonAndReceipt = ({
       type={ButtonType.Submit}
       action={buttonAction}
       slotLeft={
-        showValidatorErrors ? (
+        showValidatorErrors && areInputsFilled ? (
           <Icon iconName={IconName.Warning} tw="text-color-warning" />
         ) : undefined
       }