reuse average price function

src/constants/candles.ts

@@ -73,7 +73,6 @@ export const RESOLUTION_TO_INTERVAL_MS = {
   '1D': timeUnits.day,
 } as Record<ResolutionString, number>;
 
-
 /**
  * @description ResolutionStrings used with TradingView's charting library mapped to CandleResolution
  */

src/lib/orders.ts

@@ -1,11 +1,13 @@
 import { OrderSide } from '@dydxprotocol/v4-client-js';
+import BigNumber from 'bignumber.js';
 
 import {
   AbacusOrderStatus,
   AbacusOrderType,
   AbacusOrderTypes,
   KotlinIrEnumValues,
   Nullable,
+  SubaccountFills,
   TRADE_TYPES,
   type Asset,
   type OrderStatus,
@@ -140,3 +142,13 @@ export const getHydratedTradingData = <
 
 export const getTradeType = (orderType: string) =>
   TRADE_TYPES[orderType as KotlinIrEnumValues<typeof AbacusOrderType>];
+
+export const getAverageFillPrice = (fills: SubaccountFills) => {
+  let total = BigNumber(0);
+  let totalSize = BigNumber(0);
+  fills.forEach((fill) => {
+    total = total.plus(BigNumber(fill.price).times(fill.size));
+    totalSize = totalSize.plus(fill.size);
+  });
+  return totalSize.gt(0) ? total.div(totalSize) : null;
+};

src/lib/tradingView/dydxfeed/utils.ts

@@ -13,6 +13,8 @@ import { formatNumberOutput, OutputType } from '@/components/Output';
 import { RootStore } from '@/state/_store';
 import { getFillDetails } from '@/state/accountSelectors';
 
+import { getAverageFillPrice } from '@/lib/orders';
+
 /**
  * @description Converts times in ms to the appropriate bar time (in seconds)
  * For example, if the starting time = 5000ms, interval = 10,000ms, a value of 26,000ms would
@@ -37,12 +39,6 @@ export function getBarTime(
     .toNumber();
 }
 
-function averageFillPrice(fills: SubaccountFills) {
-  const totalSize = sum(fills.map((fill) => fill.size * fill.price));
-  const size = sum(fills.map((fill) => fill.size));
-  return totalSize / size;
-}
-
 export const getMarkForOrderFills = (
   store: RootStore,
   orderFills: SubaccountFills,
@@ -54,11 +50,15 @@ export const getMarkForOrderFills = (
   selectedLocale: SupportedLocales,
   theme: ThemeColorBase
 ): Mark => {
-  const formattedAveragePrice = formatNumberOutput(averageFillPrice(orderFills), OutputType.Fiat, {
-    decimalSeparator: localeSeparators.decimal,
-    groupSeparator: localeSeparators.group,
-    selectedLocale,
-  });
+  const formattedAveragePrice = formatNumberOutput(
+    getAverageFillPrice(orderFills),
+    OutputType.Fiat,
+    {
+      decimalSeparator: localeSeparators.decimal,
+      groupSeparator: localeSeparators.group,
+      selectedLocale,
+    }
+  );
   const formattedSize = formatNumberOutput(
     sum(orderFills.map((fill) => fill.size)),
     OutputType.Asset,

src/state/accountSelectors.ts

@@ -16,8 +16,8 @@ import {
 import { NUM_PARENT_SUBACCOUNTS, OnboardingState } from '@/constants/account';
 import { LEVERAGE_DECIMALS } from '@/constants/numbers';
 
-import { MustBigNumber } from '@/lib/numbers';
 import {
+  getAverageFillPrice,
   getHydratedTradingData,
   isOrderStatusClearable,
   isOrderStatusOpen,
@@ -476,15 +476,7 @@ const getFillsForOrderId = createAppSelector(
  * @returns the average price the order is filled at
  */
 export const getAverageFillPriceForOrder = () =>
-  createAppSelector([(s, orderId) => getFillsForOrderId(s, orderId)], (fillsForOrderId) => {
-    let total = MustBigNumber(0);
-    let totalSize = MustBigNumber(0);
-    fillsForOrderId.forEach((fill) => {
-      total = total.plus(MustBigNumber(fill.price).times(fill.size));
-      totalSize = totalSize.plus(fill.size);
-    });
-    return totalSize.gt(0) ? total.div(totalSize) : null;
-  });
+  createAppSelector([(s, orderId) => getFillsForOrderId(s, orderId)], getAverageFillPrice);
 
 /**
  * @param state