feat: evm swap deposits [OTE-700]

add test + comments and filter invalid flags

package.json

@@ -52,7 +52,7 @@
     "@cosmjs/proto-signing": "^0.32.1",
     "@cosmjs/stargate": "^0.32.1",
     "@cosmjs/tendermint-rpc": "^0.32.1",
-    "@dydxprotocol/v4-abacus": "1.8.85",
+    "@dydxprotocol/v4-abacus": "1.8.89",
     "@dydxprotocol/v4-client-js": "^1.1.27",
     "@dydxprotocol/v4-localization": "^1.1.174",
     "@emotion/is-prop-valid": "^1.3.0",

src/hooks/useStatsig.tsx

@@ -34,6 +34,5 @@ export const useAllStatsigGateValues = () => {
       return { ...acc, [gate]: checkGate(gate) };
     }, {} as StatsigConfigType);
   }, []);
-
   return allGateValues;
 };

src/lib/__test__/index.spec.ts

@@ -0,0 +1,16 @@
+import { describe, expect, it } from "vitest"
+import { StatsigConfig } from '../../constants/abacus'
+import { StatSigFlags } from "../../types/statsig"
+import abacusStateManager from "../abacus"
+
+describe('setStatsigConfigs', () => {
+    it('only sets properties that exist in the kotlin object', () => {
+        abacusStateManager.setStatsigConfigs({
+            [StatSigFlags.ffEnableEvmSwaps]: true,
+            'nonexistent_flag': true,
+        })
+        expect(StatsigConfig.ff_enable_evm_swaps).toBe(true)
+        // @ts-ignore
+        expect(StatsigConfig.nonexistent_flag).toBeUndefined()
+    })
+})

src/lib/abacus/index.ts

@@ -446,16 +446,19 @@ class AbacusStateManager {
   /**
    *
    * Updates Abacus' global StatsigConfig object.
-   * You must destructure the new flag you want to use from the config and set
-   * the relevant property on the StatsigConfig object.
+   * You must define the property in abacus first, and then add to the enum.
    *
-   * TODO: establish standardized naming conventions between
-   * statsig FF name and boolean propery in abacus StatsigConfig
-   * https://linear.app/dydx/project/feature-experimentation-6853beb333d7/overview
    */
   setStatsigConfigs = (statsigConfig: { [key in StatSigFlags]?: boolean }) => {
-    const { [StatSigFlags.ffSkipMigration]: useSkip = false } = statsigConfig;
+    const { [StatSigFlags.ffSkipMigration]: useSkip = false, ...rest } = statsigConfig;
     StatsigConfig.useSkip = useSkip;
+    Object.entries(rest).forEach(([k, v]) => {
+      // This filters out any feature flags in the enum that are not part of the
+      // kotlin statsig config object
+      if (k in StatsigConfig) {
+        StatsigConfig[k] = v;
+      }
+    });
   };
 }
 

src/types/statsig.ts

@@ -1,6 +1,12 @@
 export type StatsigConfigType = Record<StatSigFlags, boolean>;
 
+/**
+ * !README!:
+ * If you are using a flag in abacus, you must add it to the abacus
+ * StatsigConfig object first! Otherwise it won't be set in the StatsigConfig object
+ */
 export enum StatSigFlags {
   ffSkipMigration = 'ff_skip_migration',
   ffShowPredictionMarketsUi = 'ff_show_prediction_markets_ui',
+  ffEnableEvmSwaps = 'ff_enable_evm_swaps',
 }