add test + comments and filter invalid flags

src/lib/__test__/index.spec.ts

@@ -0,0 +1,16 @@
+import { describe, expect, it } from "vitest"
+import { StatsigConfig } from '../../constants/abacus'
+import { StatSigFlags } from "../../types/statsig"
+import abacusStateManager from "../abacus"
+
+describe('setStatsigConfigs', () => {
+    it('only sets properties that exist in the kotlin object', () => {
+        abacusStateManager.setStatsigConfigs({
+            [StatSigFlags.ffEnableEvmSwaps]: true,
+            'nonexistent_flag': true,
+        })
+        expect(StatsigConfig.ff_enable_evm_swaps).toBe(true)
+        // @ts-ignore
+        expect(StatsigConfig.nonexistent_flag).toBeUndefined()
+    })
+})

src/lib/abacus/index.ts

@@ -446,19 +446,18 @@ class AbacusStateManager {
   /**
    *
    * Updates Abacus' global StatsigConfig object.
-   * You must destructure the new flag you want to use from the config and set
-   * the relevant property on the StatsigConfig object.
+   * You must define the property in abacus first, and then add to the enum.
    *
-   * TODO: establish standardized naming conventions between
-   * statsig FF name and boolean propery in abacus StatsigConfig
-   * https://linear.app/dydx/project/feature-experimentation-6853beb333d7/overview
    */
   setStatsigConfigs = (statsigConfig: { [key in StatSigFlags]?: boolean }) => {
     const { [StatSigFlags.ffSkipMigration]: useSkip = false, ...rest } = statsigConfig;
     StatsigConfig.useSkip = useSkip;
     Object.entries(rest).forEach(([k, v]) => {
-      // @ts-ignore
-      StatsigConfig[k] = v;
+      // This filters out any feature flags in the enum that are not part of the
+      // kotlin statsig config object
+      if (k in StatsigConfig) {
+        StatsigConfig[k] = v;
+      }
     });
   };
 }

src/types/statsig.ts

@@ -1,5 +1,10 @@
 export type StatsigConfigType = Record<StatSigFlags, boolean>;
 
+/**
+ * !README!:
+ * If you are using a flag in abacus, you must add it to the abacus
+ * StatsigConfig object first! Otherwise it won't be set in the StatsigConfig object
+ */
 export enum StatSigFlags {
   ffSkipMigration = 'ff_skip_migration',
   ffShowPredictionMarketsUi = 'ff_show_prediction_markets_ui',