-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOB-252 : Add link to share app on profile screen #98
Merged
mike-dydx
merged 3 commits into
develop
from
mike/mob-252-add-link-to-share-app-on-profile-screen
Feb 27, 2024
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
dydx/dydxViews/dydxViews/Media.xcassets/icon_share.imageset/Contents.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "filename" : "Share.pdf", | ||
| "filename" : "icon_share.pdf", | ||
| "idiom" : "universal" | ||
| } | ||
| ], | ||
|
|
||
Binary file removed
BIN
-2.37 KB
dydx/dydxViews/dydxViews/Media.xcassets/icon_share.imageset/Share.pdf
Binary file not shown.
Binary file added
BIN
+4.15 KB
dydx/dydxViews/dydxViews/Media.xcassets/icon_share.imageset/icon_share.pdf
Binary file not shown.
64 changes: 64 additions & 0 deletions
64
dydx/dydxViews/dydxViews/_v4/Profile/TradingRewards/Components/dydxInlineShareView.swift
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // | ||
| // dydxInlineShareView.swift | ||
| // dydxUI | ||
| // | ||
| // Created by Michael Maguire on 2/23/24. | ||
| // Copyright © 2024 dYdX Trading Inc. All rights reserved. | ||
| // | ||
|
|
||
| import SwiftUI | ||
| import PlatformUI | ||
| import Utilities | ||
|
|
||
| public class dydxInlineShareViewModel: PlatformViewModel { | ||
| @Published public var shareAction: (() -> Void)? | ||
|
|
||
| private let shareCta: AttributedString = { | ||
| let localizedString = DataLocalizer.shared?.localize(path: "APP.GENERAL.SHARE_DYDX", params: nil) ?? "" | ||
| let unhighlightedString = DataLocalizer.shared?.localize(path: "APP.GENERAL.SHARE", params: nil) ?? "" | ||
|
|
||
| var attributedString = AttributedString(localizedString) | ||
| .themeFont(fontType: .text, fontSize: .medium) | ||
|
|
||
| attributedString = attributedString.themeColor(foreground: .textSecondary) | ||
| if let unhighlightedStringRange = attributedString.range(of: unhighlightedString) { | ||
| attributedString = attributedString.themeColor(foreground: .textTertiary, to: unhighlightedStringRange) | ||
| } | ||
|
|
||
| return attributedString | ||
| }() | ||
|
|
||
| public static var previewValue: dydxInlineShareViewModel = { | ||
| let vm = dydxInlineShareViewModel() | ||
| return vm | ||
| }() | ||
|
|
||
| public override func createView(parentStyle: ThemeStyle = ThemeStyle.defaultStyle, styleKey: String? = nil) -> PlatformView { | ||
| PlatformView(viewModel: self, parentStyle: parentStyle, styleKey: styleKey) { [weak self] style in | ||
| guard let self = self else { return AnyView(PlatformView.nilView) } | ||
|
|
||
| return AnyView( | ||
| HStack(alignment: .center, spacing: 6) { | ||
| Text(self.shareCta) | ||
| PlatformIconViewModel(type: .asset(name: "icon_share", bundle: .dydxView), | ||
| clip: .noClip, | ||
| size: CGSize(width: 20, height: 20), | ||
| templateColor: .textSecondary) | ||
| .createView(parentStyle: style) | ||
| } | ||
| .onTapGesture { [weak self] in | ||
| self?.shareAction?() | ||
| } | ||
| ) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #Preview { | ||
| Group { | ||
| dydxInlineShareViewModel.previewValue | ||
| .createView() | ||
| .environmentObject(ThemeSettings.shared) | ||
| .previewLayout(.sizeThatFits) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to add some tracking event for this action... maybe adding it to ShareAction's navigate() call?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good suggestion, added e854479
and tested:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have also added to the notion tracking doc