Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trcl 3132 market details #8

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Conversation

johnqh
Copy link
Contributor

@johnqh johnqh commented Nov 7, 2023

Links (dYdX Internal Use Only)

Linear Ticket: TRCL-3132 TRCL-3182


Description / Intuition

  1. Make some fine alignment changes to match v3
  2. Some market details field are no longer used in v4, removed

Before/After Screenshots or Videos

Before After

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

Copy link

linear bot commented Nov 7, 2023

TRCL-3132 Market screen alignment

See screenshot

The left side of statistics cells should align with the details text, as well as market settings (Market Name etc)

@johnqh johnqh merged commit 50b6e8c into main Nov 7, 2023
1 check passed
@mike-dydx mike-dydx added this to the v1.0.0 milestone Nov 10, 2023
mike-dydx pushed a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants