Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove setting default env #79

Merged
merged 1 commit into from
Jan 30, 2024
Merged

remove setting default env #79

merged 1 commit into from
Jan 30, 2024

Conversation

mike-dydx
Copy link
Contributor

@mike-dydx mike-dydx commented Jan 30, 2024

Description / Intuition

Abacus uses the env.json file to determine the default environment. Default environment should not be hardcoded elsewhere, otherwise the env.json's deplyment.default has no effect.

After this change, the env.json's default values are observed

@mike-dydx mike-dydx requested review from johnqh and ruixhuang January 30, 2024 19:07
@johnqh johnqh merged commit 0d9031b into main Jan 30, 2024
1 of 2 checks passed
@johnqh johnqh deleted the mike/remove-default-environment branch January 30, 2024 19:11
mike-dydx added a commit that referenced this pull request Aug 20, 2024
mike-dydx added a commit that referenced this pull request Aug 21, 2024
mike-dydx added a commit that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants