TRCL-3319 : Trading Rewards Details Screen History Card #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
mike/trcl-3319-trading-rewards-details-screen-history-card
branch
from
2c45e2b to
fc56bcc
Compare
mike-dydx
force-pushed
the
mike/trcl-3319-trading-rewards-details-screen-history-card
branch
from
5d9c02e to
f8412cf
Compare
mike-dydx
commented
Dec 8, 2023
| ForEach(list, id: \.id) { [weak self] item in | ||
| Group { | ||
| let cell = | ||
| VStack(spacing: intraItemSeparator ? 0 : 10) { |
There was a problem hiding this comment.
only change here is putting these in a vstack to standardize spacing between items
ruixhuang
reviewed
Dec 8, 2023
| import PlatformUI | ||
| import Utilities | ||
|
|
||
| public class dydxRewardsRewardView: PlatformViewModel { |
There was a problem hiding this comment.
Can we rename this to dydxRewardsRewardViewModel for consistency?
The Xcode template can be used to generate the view models with consistent syntax.
ruixhuang
reviewed
Dec 8, 2023
| .wrappedInAnyView() | ||
| } | ||
|
|
||
| let headerViewModel: PlatformViewModel = { |
| /// - Parameters: | ||
| /// - foreground: the font to apply | ||
| /// - range: the range to modify, `nil` if the entire string should be modified | ||
| mutating func themeFont(fontType: ThemeFont.FontType = .text, fontSize: ThemeFont.FontSize = .medium, to range: Range<AttributedString.Index>? = nil) { |
There was a problem hiding this comment.
I actually prefer keeping those modifier functions immutable, so we have a consistent syntax/pattern. What do you think?
There was a problem hiding this comment.
benefit i was thinking is that modifying in place skips the copy step, so potentially faster (incrementally), but since attributedstring is a struct, might be a copy on write anyways
mike-dydx
force-pushed
the
mike/trcl-3319-trading-rewards-details-screen-history-card
branch
from
3982efb to
777bbea
Compare
ruixhuang
approved these changes
Dec 8, 2023
ruixhuang
deleted the
mike/trcl-3319-trading-rewards-details-screen-history-card
branch
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* show help card in trading rewards * add padding * set up trading rewards title card * add list items to the reward history card * add view more button and header * add more periods * fix CD compilation * address comments
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* show help card in trading rewards * add padding * set up trading rewards title card * add list items to the reward history card * add view more button and header * add more periods * fix CD compilation * address comments
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* show help card in trading rewards * add padding * set up trading rewards title card * add list items to the reward history card * add view more button and header * add more periods * fix CD compilation * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: TRCL-3319 : Trading Rewards Details Screen History Card
Figma Design: card
Description / Intuition
PlatformListViewModel. Is 0 whenintraItemSeparatoristrue, 10px otherwise.Before/After Screenshots or Videos
Type of Change