Fix the issue of release build not getting the feature flag values #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
approved these changes
Dec 7, 2023
| @@ -14,7 +14,8 @@ import dydxFormatter | |||
| public final class AbacusStateManager: NSObject { | |||
| public static let shared = AbacusStateManager() | |||
|
|
|||
| public let deploymentUri = { | |||
| public lazy var deploymentUri: String = { | |||
There was a problem hiding this comment.
maybe add a private (set) here
There was a problem hiding this comment.
Oh.. lazy var should be readonly already.
There was a problem hiding this comment.
Without private set, it is not read only
mike-dydx
pushed a commit
that referenced
this pull request
Aug 20, 2024
mike-dydx
pushed a commit
that referenced
this pull request
Aug 21, 2024
mike-dydx
pushed a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Release build, the FeatureService.shared is assigned at a later time than the initialization of AbacusStateManager, which affects the value of
deploymentUrisent to Abacus. This PR makes necessary adjustment to ensuredeploymentUriis expected.Type of Change