TRCL-3367 : Update Colors to Match Design #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRCL-3367 Update Colors to Match Design
https://dydx-team.slack.com/archives/C05HH7ZDYSY/p1701832844392569 cell vs background contrast is very low, colors are incorrectly assigned |
mike-dydx
force-pushed
the
mike/fix-contrast
branch
from
23a65c7 to
8226bbd
Compare
mike-dydx
force-pushed
the
mike/fix-contrast
branch
from
ccc7a5f to
c5476bf
Compare
mike-dydx
force-pushed
the
mike/fix-contrast
branch
3 times, most recently
from
22b66b0 to
20fa625
Compare
mike-dydx
force-pushed
the
mike/fix-contrast
branch
from
20fa625 to
da4b202
Compare
ruixhuang
approved these changes
Jan 3, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* update colors to match design (better contrast) * fine tunings * update colors * fix compile * fix swiftlint to use custom config * update input borders * update redundant string
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* update colors to match design (better contrast) * fine tunings * update colors * fix compile * fix swiftlint to use custom config * update input borders * update redundant string
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* update colors to match design (better contrast) * fine tunings * update colors * fix compile * fix swiftlint to use custom config * update input borders * update redundant string
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: TRCL-3367 : Update Colors to Match Design
Description
Note, this build has been signed off by Dan for design critique.
Before/After Screenshots or Videos
Type of Change