TRCL-3281 : Add transfer entry point to profile page pt 2 - UI Tweaks #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TRCL-3281 Add transfer entry point to profile page pt 2 - UI Tweaks
the original designs have been adjusted slightly from Design: created a section with feedback
|
mike-dydx
commented
Dec 1, 2023
| let dragIndicator = Rectangle() | ||
| .themeColor(background: .layer1) | ||
| .frame(width: 36, height: 4) | ||
| .clipShape(.capsule) |
There was a problem hiding this comment.
only effective change here was rounding colors per Dan's feedback
mike-dydx
force-pushed
the
mike/trcl-3281-add-transfer-entry-point-to-profile-page-pt-2-ui-tweaks
branch
4 times, most recently
from
7c7ee3e to
c0440d5
Compare
mike-dydx
force-pushed
the
mike/trcl-3281-add-transfer-entry-point-to-profile-page-pt-2-ui-tweaks
branch
from
c0440d5 to
798c3c5
Compare
mike-dydx
commented
Dec 1, 2023
| @@ -9,7 +9,7 @@ | |||
| "layer_1": "#EDF0F2", | |||
| "layer_2": "#F9FAFB", | |||
| "layer_3": "#EDF0F2", | |||
| "layer_4": "#E0E6EB", | |||
| "layer_4": "#FFFFFF", | |||
There was a problem hiding this comment.
this color had been incorrect, see figma
ruixhuang
approved these changes
Dec 1, 2023
mike-dydx
deleted the
mike/trcl-3281-add-transfer-entry-point-to-profile-page-pt-2-ui-tweaks
branch
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
…#32) * apply design feedback * update more colors to match design * enable profile buttons always * clean up undo podfile lock changes * fix compile issue
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
…#32) * apply design feedback * update more colors to match design * enable profile buttons always * clean up undo podfile lock changes * fix compile issue
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
…#32) * apply design feedback * update more colors to match design * enable profile buttons always * clean up undo podfile lock changes * fix compile issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: TRCL-3281 : Add transfer entry point to profile page pt 2 - UI Tweaks
Figma Design: (https://www.figma.com/file/fMQodZKzn9B5aZTN5G0fLJ/dYdX-%E2%80%BA-Desktop?type=design&node-id=20085%3A7145&mode=design&t=NFDL4j2GWUVuLDWT-1)
Description / Intuition
Before/After Screenshots or Videos
Type of Change