Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRCL-3098 : Add transfer entry point to profile page #30

Merged

Conversation

mike-dydx
Copy link
Contributor

Links (dYdX Internal Use Only)

Linear Ticket: TRCL-3098 : Add transfer entry point to profile page

Figma Design: link


Description / Intuition

  • changes up the 4-buttons row in profile screen to deposit/withdraw/transfer/connect & signout
  • moves the settings and help buttons into their own row
  • changes the header layout
  • moves the wallets button action to the "switch wallet" dropdown
  • when no wallet is connected, transfer screen CTA routes to onboarding

Before/After Screenshots or Videos

Before After After (light)
Screenshot 2023-11-28 at 1 55 20 PM Screenshot 2023-11-28 at 1 55 05 PM
Screenshot 2023-11-28 at 2 03 18 PM Screenshot 2023-11-28 at 2 03 08 PM
Screenshot 2023-11-28 at 2 16 22 PM Screenshot 2023-11-28 at 2 04 01 PM Screenshot 2023-11-28 at 2 04 24 PM
Screen.Recording.2023-11-28.at.2.05.00.PM.mov

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

Copy link

linear bot commented Nov 28, 2023

TRCL-3098 Add transfer entry point to profile page

dan to create designs

  • Hard to find transfer (deposit/withdraw/transfer) entry points in app. Adding it to the 4 buttons at the top of the profile page would help the modal be more discoverable
  • Probably remove tutorials button in favor of the transfer button
  • Add a tutorial link within settings

@mike-dydx mike-dydx self-assigned this Nov 28, 2023
@mike-dydx mike-dydx merged commit 4d74286 into main Nov 29, 2023
2 checks passed
@mike-dydx mike-dydx deleted the mike/trcl-3098-add-transfer-entry-point-to-profile-page_4 branch November 29, 2023 15:49
mike-dydx added a commit that referenced this pull request Aug 20, 2024
* update profile buttons row to deposit/withdraw/transfer

* color the connect button purple

* show settings and help buttons

* add switch wallet button

* hide switch wallet button when no wallet connected

* move export secret and etherscan lookup to wallet connection screen

* add copy and ehterscan buttons to profile

* add source address receipt area

* fix button colors

* clean up

* clean up

* change visibility else case

* flip bool
mike-dydx added a commit that referenced this pull request Aug 21, 2024
* update profile buttons row to deposit/withdraw/transfer

* color the connect button purple

* show settings and help buttons

* add switch wallet button

* hide switch wallet button when no wallet connected

* move export secret and etherscan lookup to wallet connection screen

* add copy and ehterscan buttons to profile

* add source address receipt area

* fix button colors

* clean up

* clean up

* change visibility else case

* flip bool
mike-dydx added a commit that referenced this pull request Aug 21, 2024
* update profile buttons row to deposit/withdraw/transfer

* color the connect button purple

* show settings and help buttons

* add switch wallet button

* hide switch wallet button when no wallet connected

* move export secret and etherscan lookup to wallet connection screen

* add copy and ehterscan buttons to profile

* add source address receipt area

* fix button colors

* clean up

* clean up

* change visibility else case

* flip bool
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants