Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various issues on the Stop Loss/Take Profit trigger screen #295

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Fix various issues on the Stop Loss/Take Profit trigger screen #295

merged 4 commits into from
Nov 15, 2024

Conversation

ruixhuang
Copy link
Contributor


Description / Intuition

This fixes a number of issues on the Stop Loss/Take Profit trigger screen:

  1. Gain/Loss input doesn't couple with the price input.
  2. The "clear" button shows up when the input is empty.
  3. The button CTA title doesn't reflect the status of the change.
  4. Layout issue of the TP/SL value when the trigger price is longer than expected.

Also fix the market info view where the margin value and margin mode not showing up correctly.


Before/After Screenshots or Videos

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2024-11-12.at.15.00.09.mp4

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@ruixhuang ruixhuang marked this pull request as ready for review November 12, 2024 23:02
ruixhuang
ruixhuang commented Nov 12, 2024
View reviewed changes
...dxPresenters/dydxPresenters/_v4/TakeProfitStopLoss/dydxTakeProfitStopLossViewPresenter.swift
@SynchronizedLock private var pendingOrders: Int?

override init() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No logic change here.. just moving the code block up

@ruixhuang ruixhuang merged commit 9498101 into develop Nov 15, 2024
4 checks passed
@ruixhuang ruixhuang deleted the features/fix_tp_sl branch November 15, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredvu jaredvu jaredvu approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruixhuang @jaredvu