Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-629: vault landing screen floating buttons & CLI-630: deposit/withdraw screen #242

Merged

Conversation

mike-dydx
Copy link
Contributor

@mike-dydx mike-dydx commented Sep 6, 2024

Links (dYdX Internal Use Only)

Linear Tickets:

Figma Design: https://www.figma.com/design/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?node-id=9752-2618&t=GXuq3xEP3ZtLysMD-4


Description / Intuition

  • adds floating deposit/withdrawal buttons to vault landing screen
  • adds UI stubs for deposit/withdraw screen
  • fyi to review this is still all behind feature flag, undiscoverable without it turned on

Before/After Screenshots or Videos

Before After

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@mike-dydx mike-dydx requested a review from ruixhuang September 6, 2024 04:58
Copy link

linear bot commented Sep 6, 2024

@mike-dydx mike-dydx changed the title CLI-629: vault landing screen floating buttons CLI-629: vault landing screen floating buttons & CLI-630: deposit/withdraw screen Sep 6, 2024
Copy link

linear bot commented Sep 6, 2024

@mike-dydx mike-dydx merged commit ff58c8a into develop Sep 9, 2024
5 checks passed
@mike-dydx mike-dydx deleted the mike/cli-629-vault-landing-screen-floating-buttons branch September 9, 2024 19:02
mike-dydx added a commit that referenced this pull request Oct 16, 2024
…hdraw screen (#242)

* add withdraw/deposit buttons

* font size adjustment

* stubbed withdraw/deposit screen

* enabled/disabled button states/texts

---------

Co-authored-by: Mike <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants