Mike/signed commits cherry pick #231
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-lost-the-animation TRCL-3095 : Orderbook asks lost the animation
* Clean up MarketInfo data and add SwiftLint action * yml * yml1 * yml3 * Revert
…nces-in-text-color-make-both-primary TRCL-3055 : Market: differences in text color? make both secondary
* Add Swiftlint to bit pre-commit
…a-trade-ensure-user-stays-on-the-market-they TRCL-3052 : After placing a trade, ensure user stays on the market they just traded on instead of being routed back to the overall markets page or portfolio page
Feature/trcl 3132 market details
[TRCL-3160] Load app scheme from env.json and add scripts to update the info.plist
…-and-created-at-in-ios-app
* Renove CryptoSwift Pod * Revert abacus * Rebase
* attempt to parse a trading network value * look up env in available environments instead * clean up
* add edit margin button to market info view * fix layout for isolated/non-isolated stats row
* add new receipt lines * update to show change * copy updates
…unt PnL first (match web) (#201) * fix liquidation price coloring * replace app configs with forAppWithIsolatedMargins configs * update build number for local builds * update pnl state order MOB-573 * polish estimated liquidation price
* update in-line error msg ordering & change margin unit to percentage * reflect selected market in margin mode selection screen * remove sign from leverage multiplier * add variable precision to leverage * replace usage of `initialMarginFraction` with `effectiveInitialMarginFraction` * incl 3x as a target leverage * inverted coloring for cross margin and position leverage directions * remove assertion failure for now * fix display logic for isolated/cross selection * clean up
* adjust for breaking abacus changes * bump abacus * address comment #201 (comment) * replace margin calculation with abacus value * display position margin as $ instead of % in receipt * persist add/remove margin selection after dismiss and reopen * add "none" behavior for adjust margin * add margin mode to market position view, match design
…ate position row items (#205) * handle short position case for displaying liquidation price * remove viewmodel caching
* add notional value to position card * remove null checks to display empty state * cache displayed alerts to not display again * display liq/oracle price * Revert "cache displayed alerts to not display again" This reverts commit 3500ff0. * use notional instead of value total
* use skip true * bump abacus to 1.8.39 * Update AbacusStateManager.swift * add placeholder for alchemyApiKey * bump abacus to 1.8.43 * inject alchemy api key * fix set schema script * bump abacus * read from v1 configs --------- Co-authored-by: Mike <[email protected]>
* bump abacus * update v4-native-client.js to include new cctpMultiMsgWithdraw transaction type --------- Co-authored-by: Mike <[email protected]>
* create slider text input view * add target leverage slider * temp * fix custom amount switch behavior and fix overwriting bug * undo changes to platforminput * fix lines to 1 for leverage buttons * temp * fix precision * add precision to slider * clean up * address PR comments --------- Co-authored-by: Mike <[email protected]>
* integrate statsig * comment * remove FirebaseRemoteConfig * add skip to features.json * change inputs to on/off * integrate statsig with featureflag protocol * comment * change assertion failure to log * delete file * deleted code * comment * Update PodFile * bump abacus * fix pods? * remove unnecessary import --------- Co-authored-by: Mike <[email protected]>
* default to using skip * Revert "default to using skip" This reverts commit 2816867. * implement default value and session feature flag consistency * Delete contents.xcworkspacedata --------- Co-authored-by: Mike <[email protected]>
* add vault feature flag * vault screen top section stubbed out * add apr-tvl row --------- Co-authored-by: Mike <[email protected]>
* add chart radio buttons * fine tune graph * comment * comment --------- Co-authored-by: Mike <[email protected]>
Co-authored-by: Mike <[email protected]>
* add feature flag * support filtering to prediction markets * add banner * comment * add feature flag to debug menu --------- Co-authored-by: Mike <[email protected]>
Co-authored-by: Mike <[email protected]>
* make userInfo [String: Any] * pod update, adopt amplitude swift * add statsig init listener to dydxCompositeTracking * remove schemes, re-apply pod update * clean up * fixes & address PR feedback move up injectAmplitude in the lifecycle remove firebase from dydxAnalytics rename function chop characters to 36 for firebase user property --------- Co-authored-by: Mike <[email protected]>
* add footer text when prediction markets is selected filter * presenting prediction markets notice * new `present_over_full_screen` presentation style * speed up animation, improve timing for trade input presentation * add checkbox * remove test code * touchups * change logic to display prediction markets notice --------- Co-authored-by: Mike <[email protected]>
…227) * improve auto-sweep, default to subaccount 0 * clean up --------- Co-authored-by: Mike <[email protected]>
* bump abacus * turn off forcing prediction markets notice * fix empty descriptions * remove unused `id` from SharedMarketViewModel * show display ID instead of market id in market details * rename marketXYZ to assetXYZ in isolated cancellation view model * use displayid for market mode selector * SharedMarketViewModel's `tokenSymbol` and `tokenFullName` renamed to `assetId` and `assetName` * fix filter scroll truncation --------- Co-authored-by: Mike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: [Provide link to Linear ticket issue]
Figma Design: [Provide link to Figma design here if applicable]
Description / Intuition
Provide a clear and concise description of the fix(es) or change(s) you made. If possible, give some intuition behind why the changes were made or how the solution was achieved.
Before/After Screenshots or Videos
Type of Change