Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return optional feature flag value value so configured default value takes effect #225

Merged
merged 1 commit into from
Aug 9, 2024
Merged

return optional feature flag value value so configured default value takes effect #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Utilities/Utilities/_Utils/_FeatureFlags/CompositeFeatureFlagsProvider.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ public class CompositeFeatureFlagsProvider: NSObject & FeatureFlagsProtocol {
public func isOn(feature: String) -> Bool? {
switch Installation.source {
case .appStore, .jailBroken:
return remote?.isOn(feature: feature) == true
return remote?.isOn(feature: feature)
case .debug, .testFlight:
return local?.isOn(feature: feature) ?? remote?.isOn(feature: feature) ?? false
return local?.isOn(feature: feature) ?? remote?.isOn(feature: feature)
}
}

Expand Down
Loading