integrate statsig #215
Merged
integrate statsig #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
statsig-integration
branch
from
45e5b98 to
6dc0507
Compare
mike-dydx
commented
Jul 26, 2024
There was a problem hiding this comment.
@ruixhuang lmk if you don't think this should be removed. But it doesn't seem to have any effect based on current feature flags
mike-dydx
commented
Jul 26, 2024
Comment on lines
-44
to
-47
| if parser.asBoolean(FeatureService.shared?.flag(feature: "webview_popup"))?.boolValue ?? false { | ||
| configuration.preferences.javaScriptEnabled = true | ||
| configuration.preferences.javaScriptCanOpenWindowsAutomatically = true | ||
| } |
There was a problem hiding this comment.
removed since I haven't seen this feature flag, ever
mike-dydx
commented
Jul 26, 2024
Comment on lines
-23
to
-28
| switch self { | ||
| case .enable_app_rating: | ||
| return Self.obj.parser.asBoolean(FeatureService.shared?.flag(feature: rawValue))?.boolValue ?? true | ||
| case .push_notification, .force_mainnet: | ||
| return Self.obj.parser.asBoolean(FeatureService.shared?.flag(feature: rawValue))?.boolValue ?? false | ||
| } |
There was a problem hiding this comment.
preferring more statically typed version of this
mike-dydx
commented
Jul 26, 2024
| @@ -17,7 +17,7 @@ open class JsonCredentialsProvider: NSObject { | |||
|
|
|||
| private var entity: DictionaryEntity? | |||
|
|
|||
| public func key(for lookupKey: String) -> String? { | |||
| public func credential(for lookupKey: String) -> String? { | |||
There was a problem hiding this comment.
renamed to credential since key is confusing to me. The credential is not always an api key
mike-dydx
commented
Jul 26, 2024
Comment on lines
+79
to
+82
| private let newValuesSubject = PassthroughSubject<Void, Never>() | ||
| public var newValuesAvailablePublisher: AnyPublisher<Void, Never> { | ||
| newValuesSubject.eraseToAnyPublisher() | ||
| } |
There was a problem hiding this comment.
note this publisher which is made available in the FeatureFlags protocol
mike-dydx
commented
Jul 26, 2024
Comment on lines
+88
to
+91
| public func value(feature: String) -> String? { | ||
| // not yet implemented for Statsig feature flags since it is not yet needed | ||
| return nil | ||
| } |
There was a problem hiding this comment.
statsig supports non-bool feature flags, but they require more configuration. I figured we can tackle that when we get there
mike-dydx
commented
Jul 26, 2024
|
|
||
| public protocol FeatureFlagsProtocol { | ||
| var featureFlags: [String: Any]? { get } |
There was a problem hiding this comment.
The statsig SDK does not expose a list of feature flags, so this pattern had to change
mike-dydx
commented
Jul 26, 2024
Comment on lines
+16
to
+17
| func value(feature: String) -> String? | ||
| func isOn(feature: String) -> Bool? |
There was a problem hiding this comment.
prefer this more statically typed
mike-dydx
commented
Jul 26, 2024
Comment on lines
-11
to
-29
| public class FeatureFlaggedParser: ConditionalParser { | ||
| @objc override public func conditioned(_ data: Any?) -> Any? { | ||
| var conditions = self.conditions ?? [String: String]() | ||
| if let features = FeatureService.shared?.featureFlags { | ||
| for arg0 in features { | ||
| let (key, value) = arg0 | ||
| conditions[key] = parser.asString(value) | ||
| } | ||
| } | ||
| self.conditions = conditions | ||
| return super.conditioned(data) | ||
| } | ||
| } | ||
|
|
||
| extension Parser { | ||
| @objc public static var featureFlagged: Parser = { | ||
| FeatureFlaggedParser() | ||
| }() | ||
| } |
There was a problem hiding this comment.
@ruixhuang this is what was removed, but I could not see any use case for it. Let me know if I should add back
ruixhuang
previously approved these changes
Jul 26, 2024
mike-dydx
force-pushed
the
statsig-integration
branch
from
3601c7e to
b0b8ea8
Compare
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* integrate statsig * comment * remove FirebaseRemoteConfig * add skip to features.json * change inputs to on/off * integrate statsig with featureflag protocol * comment * change assertion failure to log * delete file * deleted code * comment * Update PodFile * bump abacus * fix pods? * remove unnecessary import --------- Co-authored-by: Mike <[email protected]>
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* integrate statsig * comment * remove FirebaseRemoteConfig * add skip to features.json * change inputs to on/off * integrate statsig with featureflag protocol * comment * change assertion failure to log * delete file * deleted code * comment * Update PodFile * bump abacus * fix pods? * remove unnecessary import --------- Co-authored-by: Mike <[email protected]>
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* integrate statsig * comment * remove FirebaseRemoteConfig * add skip to features.json * change inputs to on/off * integrate statsig with featureflag protocol * comment * change assertion failure to log * delete file * deleted code * comment * Update PodFile * bump abacus * fix pods? * remove unnecessary import --------- Co-authored-by: Mike <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Intuition
keytocredentialType of Change