MOB-601 : Position Card Updates #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
commented
Jul 2, 2024
Comment on lines
+46
to
+55
| let tradeSummary = input.summary | ||
| let marketId = input.marketId | ||
| let market = marketMap[marketId ?? ""] | ||
| let position = positions.first(where: { $0.id == marketId }) | ||
| self?.updateExpectedPrice(tradeSummary: tradeSummary, market: market) | ||
| self?.updateLiquidationPrice(position: position, market: market) | ||
| self?.updatePositionMargin(position: position) | ||
| self?.updatePositionLeverage(position: position) | ||
| self?.updateTradingFee(tradeSummary: tradeSummary) | ||
| self?.updateTradingRewards(tradeSummary: tradeSummary) |
There was a problem hiding this comment.
this change ensures the initial (empty) state loads
despite null values, we still want to display the receipt line titles
This reverts commit 3500ff0.
prashanDYDX
reviewed
Jul 2, 2024
| @@ -119,7 +119,9 @@ class dydxPortfolioPositionsViewPresenter: HostedViewPresenter<dydxPortfolioPosi | |||
| let item = positionsCache?[position.assetId] ?? dydxPortfolioPositionItemViewModel() | |||
|
|
|||
| let positionSize = abs(position.size.current?.doubleValue ?? 0) | |||
| let notionalValue = abs(position.valueTotal.current?.doubleValue ?? 0) | |||
There was a problem hiding this comment.
hmmm i'm using notionalTotal here, what is valueTotal?
There was a problem hiding this comment.
val valueTotal = size * oraclePrice
set(valueTotal, modified, "valueTotal", period)
val notional = valueTotal.abs()
set(notional, modified, "notionalTotal", period)
i think we want notionalTotal here
There was a problem hiding this comment.
mmm good catch, i was looking for notionalTotal earlier but it wasn't autopopulating addressed in ba3fd6c
prashanDYDX
approved these changes
Jul 2, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* add notional value to position card * remove null checks to display empty state * cache displayed alerts to not display again * display liq/oracle price * Revert "cache displayed alerts to not display again" This reverts commit 3500ff0. * use notional instead of value total
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* add notional value to position card * remove null checks to display empty state * cache displayed alerts to not display again * display liq/oracle price * Revert "cache displayed alerts to not display again" This reverts commit 3500ff0. * use notional instead of value total
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* add notional value to position card * remove null checks to display empty state * cache displayed alerts to not display again * display liq/oracle price * Revert "cache displayed alerts to not display again" This reverts commit 3500ff0. * use notional instead of value total
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: MOB-601 : Position Card Updates
Figma Design: https://www.figma.com/design/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?node-id=8654-3911&t=JinIZ2gSpoIFSaNj-4
Description / Intuition
Before/After Screenshots or Videos
Type of Change