unopened isolated positions pt2 follow up - empty state #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
mike/unopened-isolated-positions-pt2
branch
from
7dcc2c4 to
981eb80
Compare
mike-dydx
commented
Jun 19, 2024
Comment on lines
-39
to
-40
| // TODO: remove once isolated markets is supported and force released | ||
| self?.viewModel?.shouldDisplayIsolatedOrdersWarning = onboarded |
There was a problem hiding this comment.
newly unused, removed
mike-dydx
changed the title
ruixhuang
approved these changes
Jun 19, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* remove unused files * dismiss on success, update button state on submission * multi-line receipt line item title * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * put back fixed size, clean up * update button state after validation * clean up * ui tweaks * Update Package.resolved * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * update button state after validation * change routing to orders tab, populate unopened isolated position * show unopened isolated position in market info view * stub UI for cancel orders * cancel orders * remove isolated checks * remove "USD" from market names * always show positions/orders/fills in market view
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* remove unused files * dismiss on success, update button state on submission * multi-line receipt line item title * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * put back fixed size, clean up * update button state after validation * clean up * ui tweaks * Update Package.resolved * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * update button state after validation * change routing to orders tab, populate unopened isolated position * show unopened isolated position in market info view * stub UI for cancel orders * cancel orders * remove isolated checks * remove "USD" from market names * always show positions/orders/fills in market view
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* remove unused files * dismiss on success, update button state on submission * multi-line receipt line item title * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * put back fixed size, clean up * update button state after validation * clean up * ui tweaks * Update Package.resolved * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * update button state after validation * change routing to orders tab, populate unopened isolated position * show unopened isolated position in market info view * stub UI for cancel orders * cancel orders * remove isolated checks * remove "USD" from market names * always show positions/orders/fills in market view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Figma Design: https://www.figma.com/design/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?node-id=6311-27205&t=0nFUJPWkDJjgh4jh-4
Description / Intuition
Before/After Screenshots or Videos
Type of Change