unopened isolated positions pt1 #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
mike/unopened-isolated-positions
branch
from
523354c to
7c859d8
Compare
mike-dydx
force-pushed
the
mike/unopened-isolated-positions
branch
from
7c859d8 to
7a3bf31
Compare
mike-dydx
commented
Jun 14, 2024
Comment on lines
-228
to
-235
| private func updateButtonState(input: AdjustIsolatedMarginInput) { | ||
| if parser.asNumber(input.amount)?.doubleValue ?? 0 > 0 { | ||
| self.ctaButtonPresenter.viewModel?.ctaButtonState = .enabled() | ||
| } else { | ||
| self.ctaButtonPresenter.viewModel?.ctaButtonState = .disabled() | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
this was moved to validate fxn
mike-dydx
commented
Jun 14, 2024
Comment on lines
-83
to
-85
| viewModel.amount?.maxAction = { | ||
| AbacusStateManager.shared.adjustIsolatedMargin(input: "1", type: .amountpercent) | ||
| } |
There was a problem hiding this comment.
per corey's guidance, removing max button
ruixhuang
reviewed
Jun 14, 2024
|
|
||
| return VStack(spacing: 0) { | ||
| self.topContent | ||
| self.divider |
There was a problem hiding this comment.
Doesn't seem like the divider is visible from the screenshot
There was a problem hiding this comment.
addressed in de39f47
ruixhuang
previously approved these changes
Jun 14, 2024
ruixhuang
reviewed
Jun 14, 2024
| private var bottomContent: some View { | ||
| let viewOrdersStringKey: String | ||
| let viewOrdersStringParams: [String: String]? | ||
| if orderCount > 1 { |
ruixhuang
approved these changes
Jun 17, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* hide/show target leverage for margin mode selection * fix adjust margin % horizontal sizings * remove unused files * dismiss on success, update button state on submission * multi-line receipt line item title * use localized error * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * put back fixed size, clean up * hide keyboard when margin direction changes * remove max action * add local validation * update button state after validation * remove alternate validation * clean up * ui tweaks
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* hide/show target leverage for margin mode selection * fix adjust margin % horizontal sizings * remove unused files * dismiss on success, update button state on submission * multi-line receipt line item title * use localized error * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * put back fixed size, clean up * hide keyboard when margin direction changes * remove max action * add local validation * update button state after validation * remove alternate validation * clean up * ui tweaks
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* hide/show target leverage for margin mode selection * fix adjust margin % horizontal sizings * remove unused files * dismiss on success, update button state on submission * multi-line receipt line item title * use localized error * stubbed unopened isolated positions UI * wire up abacus data for unopened positions * put back fixed size, clean up * hide keyboard when margin direction changes * remove max action * add local validation * update button state after validation * remove alternate validation * clean up * ui tweaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Figma Design: https://www.figma.com/design/mKevZOfE9nj6MZpiolKYW1/dYdX-%E2%80%BA-Mobile?node-id=5962-23534&t=amLuAKC8dnKISGXT-4
Description / Intuition
part 2 will be the cancel behavior and the market info appearance (see comment)
pendingPositionsto display in Overview and Positions listspositionsto not be aPlatformListViewsince there are twoitemslistParsingErrorcomputed property tolocalizedMessageto avoid confusion with systemlocalizedDescriptionAPIBefore/After Screenshots or Videos
Type of Change