Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do not render svgs #185

Merged
merged 3 commits into from
Jun 6, 2024
Merged

do not render svgs #185

merged 3 commits into from
Jun 6, 2024

Conversation

mike-dydx
Copy link
Contributor

@mike-dydx mike-dydx commented Jun 6, 2024 •
edited
Loading

Links (dYdX Internal Use Only)

Crash Report - https://console.firebase.google.com/project/dydx-operations-services/crashlytics/app/ios:trade.dydx/issues/ecc9ca49112490f323ba62e63908198d?time=last-seven-days&types=crash&sessionEventKey=d7a215e7745b418494ca33ea98893fc2_1955421581287272308


Description / Intuition

  • fixes crash on deposit asset selection screen
  • squid provides some source/token icons as svgs which degrades performance. Either they are bad SVGs or SwiftUI is just not super compabitible with SVGs
  • have asked squid to replace SVGs with PNGs as well
  • removes trading rewards feature flag
  • fixes trading rewards to properly set selected period

Before/After Screenshots or Videos

Before After

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring or Technical Debt
  • Documentation update
  • Other (please describe: )

@mike-dydx mike-dydx requested a review from ruixhuang June 6, 2024 18:05
prashanDYDX
prashanDYDX previously approved these changes Jun 6, 2024
View reviewed changes
ruixhuang
ruixhuang previously approved these changes Jun 6, 2024
View reviewed changes
@mike-dydx mike-dydx dismissed stale reviews from ruixhuang and prashanDYDX via 421b27a June 6, 2024 20:21
@mike-dydx mike-dydx enabled auto-merge (squash) June 6, 2024 20:22
@mike-dydx mike-dydx merged commit e89aaba into develop Jun 6, 2024
2 checks passed
@mike-dydx mike-dydx deleted the mike/fix-crash branch June 6, 2024 20:51
mike-dydx added a commit that referenced this pull request Aug 20, 2024
@mike-dydx
do not render svgs (#185)
a938754 
* do not render svgs

* remove trading rewards feature flag

* set abacus historical trading reward period properly
mike-dydx added a commit that referenced this pull request Aug 21, 2024
@mike-dydx
do not render svgs (#185)
87ac523 
* do not render svgs

* remove trading rewards feature flag

* set abacus historical trading reward period properly
mike-dydx added a commit that referenced this pull request Aug 21, 2024
@mike-dydx
do not render svgs (#185)
6177b11 
* do not render svgs

* remove trading rewards feature flag

* set abacus historical trading reward period properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruixhuang ruixhuang ruixhuang approved these changes

@prashanDYDX prashanDYDX prashanDYDX left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mike-dydx @ruixhuang @prashanDYDX