add memo warning to transfer input #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike-dydx
force-pushed
the
mike/mob-536-ios-add-memo-for-token-transfer-non-usdc-only
branch
from
cdf84b8 to
22eba76
Compare
|
design notes:
|
ruixhuang
previously approved these changes
Jun 5, 2024
|
IOS should show the paste option when tap-and-hold the text input, so we can do without the paste button. |
Yeah I was thinking this as well - though having the Paste button maybe does help a bit to enforce the idea that this field should be a value copied from the CEX, not some random thing you fill out on your own? |
…nly' of github.com:dydxprotocol/v4-native-ios into mike/mob-536-ios-add-memo-for-token-transfer-non-usdc-only
prashanDYDX
approved these changes
Jun 5, 2024
mike-dydx
deleted the
mike/mob-536-ios-add-memo-for-token-transfer-non-usdc-only
branch
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* add memo warning to transfer input * update pods * ensure `enable_app_rating` defaults to true if feature flags do not work, move `completion` out of fetch callback * Revert "update pods" This reverts commit 4f95ce5. * Revert "ensure `enable_app_rating` defaults to true if feature flags do not work, move `completion` out of fetch callback" This reverts commit dcf0f9f. * add memo warning to transfer input * align x button to trailing edge
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* add memo warning to transfer input * update pods * ensure `enable_app_rating` defaults to true if feature flags do not work, move `completion` out of fetch callback * Revert "update pods" This reverts commit 4f95ce5. * Revert "ensure `enable_app_rating` defaults to true if feature flags do not work, move `completion` out of fetch callback" This reverts commit dcf0f9f. * add memo warning to transfer input * align x button to trailing edge
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* add memo warning to transfer input * update pods * ensure `enable_app_rating` defaults to true if feature flags do not work, move `completion` out of fetch callback * Revert "update pods" This reverts commit 4f95ce5. * Revert "ensure `enable_app_rating` defaults to true if feature flags do not work, move `completion` out of fetch callback" This reverts commit dcf0f9f. * add memo warning to transfer input * align x button to trailing edge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links (dYdX Internal Use Only)
Linear Ticket: MOB-536 : [iOS] Add memo for token transfer (non-USDC only)
Figma Design: https://www.figma.com/design/fMQodZKzn9B5aZTN5G0fLJ/dYdX-%E2%80%BA-Web?node-id=32590-11221&t=Po1xjzMkEe27WgXz-4
Description / Intuition
Before/After Screenshots or Videos
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-06-04.at.20.32.40.mp4
Type of Change