Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert firebase version change #180

Merged
merged 1 commit into from
Jun 4, 2024
Merged

revert firebase version change #180

merged 1 commit into from
Jun 4, 2024

Conversation

mike-dydx
Copy link
Contributor

@mike-dydx mike-dydx commented Jun 4, 2024

Description / Intuition

  • firebase lib bug so reverted to working version in 1.3.1

@mike-dydx mike-dydx marked this pull request as ready for review June 4, 2024 18:07
Revert "revert firebase version change"

This reverts commit 6ba9390.

revert firebase lib dependency
@mike-dydx mike-dydx force-pushed the mike/fix-launch-halt branch from 6ba9390 to 30fdbfd Compare June 4, 2024 18:31
@prashanDYDX
Copy link
Contributor

prashanDYDX commented Jun 4, 2024

From the linked issue: Just a quick note, we did an update to the latest v10.24.0 and it fixes the issue for us. can we just upgrade instead?

@mike-dydx
Copy link
Contributor Author

From the linked issue: Just a quick note, we did an update to the latest v10.24.0 and it fixes the issue for us. can we just upgrade instead?

10.24.0 did not seem to work when i used that version, but I can try again

@mike-dydx mike-dydx merged commit e0450f9 into develop Jun 4, 2024
1 of 2 checks passed
@mike-dydx mike-dydx deleted the mike/fix-launch-halt branch June 4, 2024 18:36
mike-dydx added a commit that referenced this pull request Aug 20, 2024
Revert "revert firebase version change"

This reverts commit 6ba9390.

revert firebase lib dependency
mike-dydx added a commit that referenced this pull request Aug 21, 2024
Revert "revert firebase version change"

This reverts commit 6ba9390.

revert firebase lib dependency
mike-dydx added a commit that referenced this pull request Aug 21, 2024
Revert "revert firebase version change"

This reverts commit 6ba9390.

revert firebase lib dependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants