fix platform list footer display logic #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…col/v4-native-ios into mike/isolated-warning-followup
mike-dydx
force-pushed
the
mike/isolated-warning-followup
branch
from
8d2dcb1 to
e95970b
Compare
ruixhuang
approved these changes
May 29, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
* fix platform list footer display logic * fix platform list footer display logic * display trigger price for trigger market orders
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* fix platform list footer display logic * fix platform list footer display logic * display trigger price for trigger market orders
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
* fix platform list footer display logic * fix platform list footer display logic * display trigger price for trigger market orders
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Intuition
previously, isolated markets warning was always being shown. Now there is conditional logic to display it. See conversation
contentChangedapproach with overridable header/footer propertiesMARKET(see conversation)Before/After Screenshots or Videos
Screen.Recording.2024-05-29.at.1.13.08.PM.mov
Type of Change