resolve build issue #172
Merged
resolve build issue #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prashanDYDX
approved these changes
May 29, 2024
ruixhuang
approved these changes
May 29, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 20, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
mike-dydx
added a commit
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Intuition
tough one to explain, but what seems to have been the issue is that dydxAnalytics had a dependency on abacus in the Podfile. dydxPresenters also has a dependency on dydxAnalytics, configured in the workspace instead of the pod file. This is common practice for the project. Perhaps there was abacus duplication given the dependency graph and that was causing trouble.
changes in this PR are to remove abacus dependencies from dydxAnalytics. Seems to resolve the sporatic build/run issue. As a result of the dependency removal, had to move some files into dydxPresenters framework